From fc40c059fa1e04006651cbccc0d3f4943e94abf7 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Sun, 8 Oct 2017 10:16:54 +0200 Subject: broadband-modem-mbim: plug memleak when querying previous unlock retries ==15673== 240 (40 direct, 200 indirect) bytes in 1 blocks are definitely lost in loss record 4,341 of 4,535 ==15673== at 0x647F014: g_type_create_instance (in /usr/lib/libgobject-2.0.so.0.5200.3) ==15673== by 0x6460027: ??? (in /usr/lib/libgobject-2.0.so.0.5200.3) ==15673== by 0x6461A54: g_object_newv (in /usr/lib/libgobject-2.0.so.0.5200.3) ==15673== by 0x6462213: g_object_new (in /usr/lib/libgobject-2.0.so.0.5200.3) ==15673== by 0x4E97C33: mm_unlock_retries_new (mm-unlock-retries.c:217) ==15673== by 0x4E97A6F: mm_unlock_retries_new_from_dictionary (mm-unlock-retries.c:171) ==15673== by 0x170B09: mm_iface_modem_get_unlock_retries (mm-iface-modem.c:2942) ==15673== by 0x1DB0A4: pin_query_unlock_retries_ready (mm-broadband-modem-mbim.c:782) ==15673== by 0x613AD52: ??? (in /usr/lib/libgio-2.0.so.0.5200.3) ==15673== by 0x613B775: ??? (in /usr/lib/libgio-2.0.so.0.5200.3) ==15673== by 0x57D525D: transaction_task_complete_and_free (mbim-device.c:246) ==15673== by 0x57D6086: process_message (mbim-device.c:666) --- src/mm-broadband-modem-mbim.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src') diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c index fc13911d..d6562088 100644 --- a/src/mm-broadband-modem-mbim.c +++ b/src/mm-broadband-modem-mbim.c @@ -787,6 +787,7 @@ pin_query_unlock_retries_ready (MbimDevice *device, MM_MODEM_LOCK_SIM_PIN, previous_sim_pin_retries); } + g_object_unref (previous_retries); } /* According to the MBIM specification, RemainingAttempts is set to -- cgit v1.2.3-70-g09d2