From 9da04f6158cd64a92a41e3c9795f3e94afc26600 Mon Sep 17 00:00:00 2001 From: Daniel Hofmann Date: Sun, 24 Sep 2023 19:05:44 +0000 Subject: broadband-modem-qmi: Treat QMI_VOICE_USER_ACTION_UNKNOWN as QMI_VOICE_USER_ACTION_NOT_REQUIRED. This fixes a bug where network-initiated USSD-Notify messages were not processed (and forwarded to higher-level applications) at all, while they should have been processed (and forwareded to higher-level applications). Previously, when there was a USSD conversation between the user and the network, the last message from the network (which, by definition, is not a message with user_action==QMI_VOICE_USER_ACTION_REQUIRED) would be silently dropped. The cause is a mismatch between the modem sending user_action==QMI_VOICE_USER_ACTION_UNKNOWN while old ModemManager expecting user_action==QMI_VOICE_USER_ACTION_NOT_REQUIRED. --- src/mm-broadband-modem-qmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c index 265f6d5a..239834bd 100644 --- a/src/mm-broadband-modem-qmi.c +++ b/src/mm-broadband-modem-qmi.c @@ -9805,6 +9805,7 @@ process_ussd_message (MMBroadbandModemQmi *self, switch (user_action) { case QMI_VOICE_USER_ACTION_NOT_REQUIRED: + case QMI_VOICE_USER_ACTION_UNKNOWN: /* Treat unknown user action as user action not required. */ /* no response, or a response to user's request? */ if (!utf8 || task) break; @@ -9822,7 +9823,6 @@ process_ussd_message (MMBroadbandModemQmi *self, mm_iface_modem_3gpp_ussd_update_network_request (MM_IFACE_MODEM_3GPP_USSD (self), utf8); g_clear_pointer (&utf8, g_free); break; - case QMI_VOICE_USER_ACTION_UNKNOWN: default: /* Not an indication */ break; -- cgit v1.2.3-70-g09d2