From 9b8fb447b0b2b967fe7fbb980ed2debd12be67ed Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Wed, 19 Aug 2020 14:48:12 +0200 Subject: broadband-modem-qmi: fix type comparison MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Only applicable when building with WITH_NEWEST_QMI_COMMANDS. mm-broadband-modem-qmi.c: In function ‘process_common_info’: mm-broadband-modem-qmi.c:2924:20: error: comparison is always false due to limited range of data type [-Werror=type-limits] 2924 | if (mnc[2] == 0xFF) { | ^~ --- src/mm-broadband-modem-qmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c index d57bab94..50050b8f 100644 --- a/src/mm-broadband-modem-qmi.c +++ b/src/mm-broadband-modem-qmi.c @@ -2921,7 +2921,7 @@ process_common_info (QmiNasServiceStatus service_status, if (network_id_valid) { *mm_operator_id = g_malloc (7); memcpy (*mm_operator_id, mcc, 3); - if (mnc[2] == 0xFF) { + if ((guint8)mnc[2] == 0xFF) { memcpy (&((*mm_operator_id)[3]), mnc, 2); (*mm_operator_id)[5] = '\0'; } else { -- cgit v1.2.3-70-g09d2