From 969189d42cc88bce9bdd6fb5e387352a02f81f2a Mon Sep 17 00:00:00 2001 From: Ting-Yuan Huang Date: Sat, 14 May 2016 15:25:32 +0800 Subject: plugin-manager: protect mm_plugin_{major,minor}_version This patch makes declarations bind to definitions within the same module to prevent the potential ambiguity if referenced directly. AddressSanitizer think they violated one definition rule, although those symbols are accessed by address through their modules and do not depend on the order of the libararies loaded. --- src/mm-plugin.h | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src') diff --git a/src/mm-plugin.h b/src/mm-plugin.h index ee03686b..04916794 100644 --- a/src/mm-plugin.h +++ b/src/mm-plugin.h @@ -31,6 +31,15 @@ #define MM_PLUGIN_MAJOR_VERSION 4 #define MM_PLUGIN_MINOR_VERSION 0 +#if defined (G_HAVE_GNUC_VISIBILITY) +#define VISIBILITY __attribute__((visibility("protected"))) +#else +#define VISIBILITY +#endif + +#define MM_PLUGIN_DEFINE_MAJOR_VERSION VISIBILITY int mm_plugin_major_version = MM_PLUGIN_MAJOR_VERSION; +#define MM_PLUGIN_DEFINE_MINOR_VERSION VISIBILITY int mm_plugin_minor_version = MM_PLUGIN_MINOR_VERSION; + #define MM_TYPE_PLUGIN (mm_plugin_get_type ()) #define MM_PLUGIN(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), MM_TYPE_PLUGIN, MMPlugin)) #define MM_PLUGIN_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), MM_TYPE_PLUGIN, MMPluginClass)) -- cgit v1.2.3-70-g09d2