From 6f103c136660eee618d6b38c69d3ba91e3b41921 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander@lanedo.com>
Date: Wed, 1 Feb 2012 22:29:39 +0100
Subject: sms-list: don't signal completed messages

We will instead not export an SMS until completed and assembled
---
 src/mm-iface-modem-messaging.c | 13 -------------
 src/mm-sms-list.c              | 15 ---------------
 src/mm-sms-list.h              |  3 ---
 3 files changed, 31 deletions(-)

(limited to 'src')

diff --git a/src/mm-iface-modem-messaging.c b/src/mm-iface-modem-messaging.c
index 053b670c..7f21822f 100644
--- a/src/mm-iface-modem-messaging.c
+++ b/src/mm-iface-modem-messaging.c
@@ -173,15 +173,6 @@ sms_added (MMSmsList *list,
     mm_gdbus_modem_messaging_emit_added (skeleton, sms_path, received);
 }
 
-static void
-sms_completed (MMSmsList *list,
-               const gchar *sms_path,
-               MmGdbusModemMessaging *skeleton)
-{
-    mm_dbg ("Completed SMS at '%s'", sms_path);
-    mm_gdbus_modem_messaging_emit_completed (skeleton, sms_path);
-}
-
 static void
 sms_deleted (MMSmsList *list,
              const gchar *sms_path,
@@ -407,10 +398,6 @@ interface_enabling_step (EnablingContext *ctx)
                           MM_SMS_ADDED,
                           G_CALLBACK (sms_added),
                           ctx->skeleton);
-        g_signal_connect (list,
-                          MM_SMS_COMPLETED,
-                          G_CALLBACK (sms_completed),
-                          ctx->skeleton);
         g_signal_connect (list,
                           MM_SMS_DELETED,
                           G_CALLBACK (sms_deleted),
diff --git a/src/mm-sms-list.c b/src/mm-sms-list.c
index dbe4c746..6b1082d6 100644
--- a/src/mm-sms-list.c
+++ b/src/mm-sms-list.c
@@ -40,7 +40,6 @@ static GParamSpec *properties[PROP_LAST];
 
 enum {
     SIGNAL_ADDED,
-    SIGNAL_COMPLETED,
     SIGNAL_DELETED,
     SIGNAL_LAST
 };
@@ -224,11 +223,6 @@ take_multipart (MMSmsList *self,
                        received);
     }
 
-    /* Check if completed */
-    if (mm_sms_multipart_is_complete (sms))
-        g_signal_emit (self, signals[SIGNAL_COMPLETED], 0,
-                       mm_sms_get_path (sms));
-
     return TRUE;
 }
 
@@ -358,15 +352,6 @@ mm_sms_list_class_init (MMSmsListClass *klass)
                       mm_marshal_VOID__STRING_BOOLEAN,
                       G_TYPE_NONE, 2, G_TYPE_STRING, G_TYPE_BOOLEAN);
 
-    signals[SIGNAL_COMPLETED] =
-        g_signal_new (MM_SMS_COMPLETED,
-                      G_OBJECT_CLASS_TYPE (object_class),
-                      G_SIGNAL_RUN_FIRST,
-                      G_STRUCT_OFFSET (MMSmsListClass, sms_completed),
-                      NULL, NULL,
-                      mm_marshal_VOID__STRING,
-                      G_TYPE_NONE, 1, G_TYPE_STRING);
-
     signals[SIGNAL_DELETED] =
         g_signal_new (MM_SMS_DELETED,
                       G_OBJECT_CLASS_TYPE (object_class),
diff --git a/src/mm-sms-list.h b/src/mm-sms-list.h
index a639255b..f2eca319 100644
--- a/src/mm-sms-list.h
+++ b/src/mm-sms-list.h
@@ -36,7 +36,6 @@ typedef struct _MMSmsListPrivate MMSmsListPrivate;
 #define MM_SMS_LIST_MODEM "sms-list-modem"
 
 #define MM_SMS_ADDED     "sms-added"
-#define MM_SMS_COMPLETED "sms-completed"
 #define MM_SMS_DELETED   "sms-deleted"
 
 struct _MMSmsList {
@@ -51,8 +50,6 @@ struct _MMSmsListClass {
     void (*sms_added)     (MMSmsList *self,
                            const gchar *sms_path,
                            gboolean received);
-    void (*sms_completed) (MMSmsList *self,
-                           const gchar *sms_path);
     void (*sms_deleted)   (MMSmsList *self,
                            const gchar *sms_path);
 };
-- 
cgit v1.2.3-70-g09d2