From 1564b54cff0b7097c93f4152a320da5cbbfa2b16 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Thu, 11 May 2023 11:13:35 +0000 Subject: broadband-modem-mbim: non-zero interval when enabling thresholds Fix bug in Fibocom FM350 modem where a non-zero signal strength interval needs to be configured as part of threshold setup. Fixes #733 --- src/mm-broadband-modem-mbim.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c index e18fd7af..6c6536f1 100644 --- a/src/mm-broadband-modem-mbim.c +++ b/src/mm-broadband-modem-mbim.c @@ -6850,8 +6850,13 @@ modem_signal_setup_thresholds (MMIfaceModemSignal *self, if (error_rate_threshold) coded_error_rate_threshold = 1; /* minimum value when enabled */ + /* setting signal strength interval to 0 disables threshold-based + * notifications on certain modems (FM350). + * hence, it is being set to 5 as per FBC's recommendation. + * typically, setting this parameter to 0 should make the modem + * set the value to its internal default as per spec. */ message = (mbim_message_signal_state_set_new ( - 0, /* signal strength interval set to default always */ + 5, /* non-zero default signal strength interval */ coded_rssi_threshold, coded_error_rate_threshold, NULL)); -- cgit v1.2.3-70-g09d2