From 0d8a5e2a43e6baff0c282a3d2b15d03063c48199 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Fri, 3 Jan 2020 22:25:44 +0100 Subject: iface-modem-voice: fix segfault when voice support check fails The error returned in support_check_finish() should be treated as optional, as in all the other optional feature interfaces. Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/172 --- src/mm-iface-modem-voice.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index 9c3b84c5..592afc41 100644 --- a/src/mm-iface-modem-voice.c +++ b/src/mm-iface-modem-voice.c @@ -2813,8 +2813,10 @@ check_support_ready (MMIfaceModemVoice *self, GError *error = NULL; if (!MM_IFACE_MODEM_VOICE_GET_INTERFACE (self)->check_support_finish (self, res, &error)) { - mm_dbg ("Voice support check failed: '%s'", error->message); - g_error_free (error); + if (error) { + mm_dbg ("Voice support check failed: '%s'", error->message); + g_error_free (error); + } g_task_return_new_error (task, MM_CORE_ERROR, MM_CORE_ERROR_UNSUPPORTED, "Voice not supported"); g_object_unref (task); return; -- cgit v1.2.3-70-g09d2