From a65fa9e1428b7464a13de1320270b4711dd13be0 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Mon, 23 Dec 2019 13:59:29 +0100 Subject: iface-modem-time: fix warnings with -Wimplicit-fallthrough MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit mm-iface-modem-time.c: In function ‘interface_disabling_step’: mm-iface-modem-time.c:484:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 484 | ctx->step++; | ~~~~~~~~~^~ mm-iface-modem-time.c:486:5: note: here 486 | case DISABLING_STEP_CANCEL_NETWORK_TIMEZONE_UPDATE: | ^~~~ ... --- src/mm-iface-modem-time.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'src/mm-iface-modem-time.c') diff --git a/src/mm-iface-modem-time.c b/src/mm-iface-modem-time.c index adcf36ee..3aa20820 100644 --- a/src/mm-iface-modem-time.c +++ b/src/mm-iface-modem-time.c @@ -480,14 +480,14 @@ interface_disabling_step (GTask *task) switch (ctx->step) { case DISABLING_STEP_FIRST: - /* Fall down to next step */ ctx->step++; + /* fall through */ case DISABLING_STEP_CANCEL_NETWORK_TIMEZONE_UPDATE: /* Stop and cleanup context */ stop_network_timezone (self); - /* Fall down to next step */ ctx->step++; + /* fall through */ case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS: /* Allow cleaning up unsolicited events */ @@ -499,8 +499,8 @@ interface_disabling_step (GTask *task) task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case DISABLING_STEP_CLEANUP_UNSOLICITED_EVENTS: /* Allow cleaning up unsolicited events */ @@ -512,8 +512,8 @@ interface_disabling_step (GTask *task) task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case DISABLING_STEP_LAST: /* We are done without errors! */ @@ -649,14 +649,14 @@ interface_enabling_step (GTask *task) switch (ctx->step) { case ENABLING_STEP_FIRST: - /* Fall down to next step */ ctx->step++; + /* fall through */ case ENABLING_STEP_SETUP_NETWORK_TIMEZONE_RETRIEVAL: /* We start it and schedule it to run asynchronously */ start_network_timezone (self); - /* Fall down to next step */ ctx->step++; + /* fall through */ case ENABLING_STEP_SETUP_UNSOLICITED_EVENTS: /* Allow setting up unsolicited events */ @@ -668,8 +668,8 @@ interface_enabling_step (GTask *task) task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case ENABLING_STEP_ENABLE_UNSOLICITED_EVENTS: /* Allow setting up unsolicited events */ @@ -681,8 +681,8 @@ interface_enabling_step (GTask *task) task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case ENABLING_STEP_LAST: /* We are done without errors! */ @@ -805,8 +805,8 @@ interface_initialization_step (GTask *task) supported_quark = (g_quark_from_static_string ( SUPPORTED_TAG)); - /* Fall down to next step */ ctx->step++; + /* fall through */ case INITIALIZATION_STEP_CHECK_SUPPORT: if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self), @@ -832,8 +832,8 @@ interface_initialization_step (GTask *task) /* If there is no implementation to check support, assume we DON'T * support it. */ } - /* Fall down to next step */ ctx->step++; + /* fall through */ case INITIALIZATION_STEP_FAIL_IF_UNSUPPORTED: if (!GPOINTER_TO_UINT (g_object_get_qdata (G_OBJECT (self), @@ -845,8 +845,8 @@ interface_initialization_step (GTask *task) g_object_unref (task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case INITIALIZATION_STEP_LAST: /* We are done without errors! */ -- cgit v1.2.3-70-g09d2