From 4bdfd25de18bc6abaae6197f5f4646586c0da511 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Wed, 7 Mar 2012 17:07:36 +0100 Subject: base-modem: when getting best AT port, assume we may have lost specific ports Don't assume that primary port is always set. --- src/mm-base-modem.c | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) (limited to 'src/mm-base-modem.c') diff --git a/src/mm-base-modem.c b/src/mm-base-modem.c index 9f187306..668199b9 100644 --- a/src/mm-base-modem.c +++ b/src/mm-base-modem.c @@ -365,22 +365,21 @@ mm_base_modem_get_best_at_port (MMBaseModem *self, /* Decide which port to use */ port = mm_base_modem_get_port_primary (self); - g_assert (port); - if (mm_port_get_connected (MM_PORT (port))) { - /* If primary port is connected, check if we can get the secondary - * port */ - port = mm_base_modem_get_port_secondary (self); - if (!port) { - /* If we don't have a secondary port, we need to halt the AT - * operation */ - g_set_error (error, - MM_CORE_ERROR, - MM_CORE_ERROR_CONNECTED, - "No port available to run command"); - } - } - - return port; + if (port && !mm_port_get_connected (MM_PORT (port))) + return port; + + /* If primary port is connected, check if we can get the secondary + * port */ + port = mm_base_modem_get_port_secondary (self); + if (port && !mm_port_get_connected (MM_PORT (port))) + return port; + + /* Otherwise, we cannot get any port */ + g_set_error (error, + MM_CORE_ERROR, + MM_CORE_ERROR_CONNECTED, + "No port available to run command"); + return NULL; } static void -- cgit v1.2.3-70-g09d2