From 4e5ad5585a56a6973003a621c92415e7c9b9014c Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Thu, 6 Jul 2017 10:59:09 +0200 Subject: base-call: no need to keep a modem reference around The mm_base_modem_at_command() async calls keep a modem reference valid for as long as the operation and its completion handler are run, so there really is no need for the caller (the call operation) to keep a reference to the modem object itself. --- src/mm-base-call.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/mm-base-call.c') diff --git a/src/mm-base-call.c b/src/mm-base-call.c index 0896259b..4536eafb 100644 --- a/src/mm-base-call.c +++ b/src/mm-base-call.c @@ -641,7 +641,6 @@ call_start (MMBaseCall *self, gchar *cmd; task = g_task_new (self, NULL, callback, user_data); - g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref); cmd = g_strdup_printf ("ATD%s;", mm_gdbus_call_get_number (MM_GDBUS_CALL (self))); mm_base_modem_at_command (self->priv->modem, @@ -724,7 +723,6 @@ call_accept (MMBaseCall *self, GTask *task; task = g_task_new (self, NULL, callback, user_data); - g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref); mm_base_modem_at_command (self->priv->modem, "ATA", @@ -791,7 +789,6 @@ call_hangup (MMBaseCall *self, GTask *task; task = g_task_new (self, NULL, callback, user_data); - g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref); mm_base_modem_at_command (self->priv->modem, "+CHUP", @@ -842,7 +839,6 @@ call_send_dtmf (MMBaseCall *self, gchar *cmd; task = g_task_new (self, NULL, callback, user_data); - g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref); cmd = g_strdup_printf ("AT+VTS=%c", dtmf[0]); mm_base_modem_at_command (self->priv->modem, @@ -865,7 +861,6 @@ call_delete (MMBaseCall *self, GTask *task; task = g_task_new (self, NULL, callback, user_data); - g_task_set_task_data (task, g_object_ref (self->priv->modem), g_object_unref); g_task_return_boolean (task, TRUE); g_object_unref (task); } -- cgit v1.2.3-70-g09d2