From 3a7d4b12005da1e5e861b8a213814c8743e5208f Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Wed, 21 Feb 2018 13:38:53 +0100 Subject: ublox: ignore ttyACM0 in the TOBY-L4 We used ttyACM0 as secondary port until now, just because we had an extra AT capable TTY around in addition to the main control ttyACM2 port. Turns out, using this ttyACM0 may actually break the connection setup in the wwan interface in a bad way (e.g. not allowing DHCP setup). The suggestion from u-blox and Intel is to fully ignore ttyACM0; and given that we no longer need any primary/secondary port logic, we just remove all the associated udev tags. --- plugins/ublox/mm-plugin-ublox.c | 29 ----------------------------- 1 file changed, 29 deletions(-) (limited to 'plugins/ublox/mm-plugin-ublox.c') diff --git a/plugins/ublox/mm-plugin-ublox.c b/plugins/ublox/mm-plugin-ublox.c index 5ee09a20..fc9ec0c6 100644 --- a/plugins/ublox/mm-plugin-ublox.c +++ b/plugins/ublox/mm-plugin-ublox.c @@ -47,34 +47,6 @@ create_modem (MMPlugin *self, product)); } -static gboolean -grab_port (MMPlugin *self, - MMBaseModem *modem, - MMPortProbe *probe, - GError **error) -{ - MMPortSerialAtFlag pflags = MM_PORT_SERIAL_AT_FLAG_NONE; - MMKernelDevice *port; - MMPortType port_type; - - port_type = mm_port_probe_get_port_type (probe); - port = mm_port_probe_peek_port (probe); - - if (mm_kernel_device_get_property_as_boolean (port, "ID_MM_UBLOX_PRIMARY_PORT")) { - mm_dbg ("(%s/%s)' port flagged as primary", - mm_port_probe_get_port_subsys (probe), - mm_port_probe_get_port_name (probe)); - pflags = MM_PORT_SERIAL_AT_FLAG_PRIMARY; - } else if (mm_kernel_device_get_property_as_boolean (port, "ID_MM_UBLOX_SECONDARY_PORT")) { - mm_dbg ("(%s/%s) port flagged as secondary", - mm_port_probe_get_port_subsys (probe), - mm_port_probe_get_port_name (probe)); - pflags = MM_PORT_SERIAL_AT_FLAG_SECONDARY; - } - - return mm_base_modem_grab_port (modem, port, port_type, pflags, error); -} - /*****************************************************************************/ /* Custom init context */ @@ -295,5 +267,4 @@ mm_plugin_ublox_class_init (MMPluginUbloxClass *klass) MMPluginClass *plugin_class = MM_PLUGIN_CLASS (klass); plugin_class->create_modem = create_modem; - plugin_class->grab_port = grab_port; } -- cgit v1.2.3-70-g09d2