From 681d5d29d577ab4d2d822bb42ccbb74ac7d73b95 Mon Sep 17 00:00:00 2001 From: Stephan Gerhold Date: Sat, 5 Jun 2021 16:31:33 +0200 Subject: qcom-soc: Add support for WWAN subsystem instead of RPMSG Recent Linux kernel versions have introduced a generic WWAN subsystem that provides various char devices for QMI, AT etc, similar to the subsystem-specific char devices for USB or RPMSG. The RPMSG char device for Qualcomm SoCs (e.g. MSM8916/MSM8974) are particularly complicated to work with because they need to be explicitly created from userspace with rpmsgexport and don't show up automatically. However, it turns out it's fairly simple to wrap the RPMSG subsystem in a simple driver for the WWAN subsystem. This has several advantages: - We can drop support for the special RPMSG char devices entirely at some point. - The WWAN char devices show up automatically, without having to export them explicitly, making ModemManager work out of the box on these devices. For now, just support using the WWAN subsystem alternatively for the qcom-soc plugin. Later we can consider dropping the old RPMSG code. --- plugins/qcom-soc/77-mm-qcom-soc.rules | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'plugins/qcom-soc/77-mm-qcom-soc.rules') diff --git a/plugins/qcom-soc/77-mm-qcom-soc.rules b/plugins/qcom-soc/77-mm-qcom-soc.rules index 381fbfd9..32195c1a 100644 --- a/plugins/qcom-soc/77-mm-qcom-soc.rules +++ b/plugins/qcom-soc/77-mm-qcom-soc.rules @@ -5,6 +5,7 @@ ACTION!="add|change|move|bind", GOTO="mm_qcom_soc_end" # Process only known net and rpmsg ports SUBSYSTEM=="net", DRIVERS=="bam-dmux", GOTO="mm_qcom_soc_process" SUBSYSTEM=="net", DRIVERS=="ipa", GOTO="mm_qcom_soc_process" +SUBSYSTEM=="wwan", DRIVERS=="qcom-q6v5-mss", GOTO="mm_qcom_soc_process" SUBSYSTEM=="rpmsg", DRIVERS=="qcom-q6v5-mss", GOTO="mm_qcom_soc_process" GOTO="mm_qcom_soc_end" @@ -14,7 +15,7 @@ LABEL="mm_qcom_soc_process" # Add a common physdev UID to all ports in the Qualcomm SoC, so that they # are all bound together to the same modem object. # -# The MSM8916, MSM8974, .... Qualcomm SoCs use the combination of RPMSG +# The MSM8916, MSM8974, .... Qualcomm SoCs use the combination of RPMSG/WWAN # based control ports plus BAM-DMUX based network ports. # ENV{ID_MM_PHYSDEV_UID}="qcom-soc" -- cgit v1.2.3-70-g09d2