From f49f325715b8bc8078bafa3339f1d77dbe35392e Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Wed, 16 Jan 2019 15:56:59 +0100 Subject: libmm-glib,firmware-update-settings: skip dictionary if method is NONE No need to process the detailed dictionary if no explicit method is reported as supported. Avoids unnecessary warnings: $ mmcli -m 1 --firmware-status ** (mmcli:6887): WARNING **: 15:52:54.664: Invalid initial update settings: Missing required 'device-ids' setting error: firmware status unsupported --- libmm-glib/mm-firmware-update-settings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libmm-glib/mm-firmware-update-settings.c') diff --git a/libmm-glib/mm-firmware-update-settings.c b/libmm-glib/mm-firmware-update-settings.c index 01c8bc8d..37c8381e 100644 --- a/libmm-glib/mm-firmware-update-settings.c +++ b/libmm-glib/mm-firmware-update-settings.c @@ -255,7 +255,7 @@ mm_firmware_update_settings_new_from_variant (GVariant *variant, g_variant_get (variant, "(u@a{sv})", &method, &dictionary); self = mm_firmware_update_settings_new (method); - if (dictionary) { + if ((method != MM_MODEM_FIRMWARE_UPDATE_METHOD_NONE) && dictionary) { GVariantIter iter; gchar *key; GVariant *value; -- cgit v1.2.3-70-g09d2