From c6cf7cf094f9974e8f5b9d3640e7d34ebc2a0482 Mon Sep 17 00:00:00 2001 From: Ben Chan Date: Sat, 3 Aug 2019 09:12:57 -0700 Subject: libmm-glib,firmware-update-settings: handle null self pointer mm_firmware_update_settings_get_variant() checks for a null `self' pointer when accessing `self->priv->method', but doesn't perform the null check when accessing other members of MMFirmwareUpdateSettingsPrivate. This patch fixes mm_firmware_update_settings_get_variant() to fully handle a null `self' pointer. --- libmm-glib/mm-firmware-update-settings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libmm-glib/mm-firmware-update-settings.c') diff --git a/libmm-glib/mm-firmware-update-settings.c b/libmm-glib/mm-firmware-update-settings.c index 37c8381e..fc8a45bb 100644 --- a/libmm-glib/mm-firmware-update-settings.c +++ b/libmm-glib/mm-firmware-update-settings.c @@ -174,7 +174,7 @@ mm_firmware_update_settings_get_variant (MMFirmwareUpdateSettings *self) g_variant_builder_add (&builder, "u", method); g_variant_builder_open (&builder, G_VARIANT_TYPE ("a{sv}")); - { + if (self) { g_variant_builder_add (&builder, "{sv}", PROPERTY_DEVICE_IDS, -- cgit v1.2.3-70-g09d2