From 35e20a48c8b16ae744c4ca3082f70e8aa674c2f4 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Thu, 25 Feb 2021 14:43:22 +0100 Subject: api,modem: deprecate the 'MaxBearers' property This property was never initialized with a correct value, we would always use the same value as used for MaxActiveBearers, which isn't technically right. Just suggest to ignore this property, and flag it as deprecated. In addition to deprecating the API property, we will internally no longer limit the amount of bearer objects that may be created with different connection settings. The bearer object exposed in DBus is a representation of the connection that may be setup, and so we can hold as many representations as we want as long as the amount of connected bearers doesn't exceed the maximum amount for each modem. Leaving around the disconnected modems also serves another purpose. Each bearer holds information about the amount of times a connection with it has been attempted, and the amount of data transferred through it. If we use the Simple.Connect() method to connect the modem using different bearer settings, we won't lose the information of the past connection attempts with different settings. --- introspection/org.freedesktop.ModemManager1.Modem.xml | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'introspection') diff --git a/introspection/org.freedesktop.ModemManager1.Modem.xml b/introspection/org.freedesktop.ModemManager1.Modem.xml index 25527394..d75f86fc 100644 --- a/introspection/org.freedesktop.ModemManager1.Modem.xml +++ b/introspection/org.freedesktop.ModemManager1.Modem.xml @@ -337,6 +337,12 @@ while GSM/UMTS devices typically support three or more, and any LTE-capable device (whether LTE-only, GSM/UMTS-capable, and/or CDMA2000-capable) also typically support three or more. + + Deprecated: 1.18.0. There is no way to query the modem how many bearers + it supports, so the value exposed in this property in all the different + implementations is always equal to the value in + #org.freedesktop.ModemManager1.Modem:MaxActiveBearers, so there is no + point in using this property. --> -- cgit v1.2.3-70-g09d2