aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2012-03-15tests: serial port tests don't need errors headerAleksander Morgado
2012-03-13at-serial-port: new property to control whether echo removal should be appliedAleksander Morgado
2012-03-01gsm: retry sending SMS in PDU mode if text fails and PDU is supportedDan Williams
In the future we'll just default to PDU mode.
2012-02-29modem-helpers: plug memleakAleksander Morgado
g_match_info_fetch() returns always a heap-allocated string which should be freed by the caller.
2012-02-28core: rework port grabbing and organizationDan Williams
Make port roles more flexible. We have modems that do PPP on interfaces other than the primary interface, and that wasn't possible with the old code. So clean up all that logic and move the port organization code into the core so we can reduce code in the plugins. In the new world order, the plugins say whether the port is a QCDM port, an AT port, or ignored. If it's an AT port the plugins get to tag it as primary, secondary, or PPP, or any combination of the 3. This allows for modems where PPP should really be done on the secondary port (Huawei E220, Sierra devices) so that the primary port stays open for command and status. Modem subclasses no longer get asked to handle port grabbing themselves. Instead, that's now done by the generic classes (MMGenericCdma and MMGenericGsm) and the plugins are notified when a port is grabbed so they can add unsolicited response handlers for it. After all ports are grabbed by the generic classes, they get "organized", which assigns various ports to the roles of PRIMARY, SECONDARY, DATA, and QCDM based on specific rules and hints that the plugin provided (which are expressed as MMAtPortFlags). The plugins then have a chance to perform fixups on the primary port if they choose. The plugin code is responsible for determining the port hints (ie MMAtPortFlags) at probe time, instead of having a combination of the plugin and the modem class do the job. This simplifies things greatly for the plugins at the expense of more complicated logic in the core.
2012-02-25cdma: fix crash on NULL error (bgo #670145)Tom Goetz
2012-02-18charsets: plug memleakAleksander Morgado
The string passed to utils_bin2hexstr() needs to be freed afterwards.
2012-02-17gsm: don't query PS network registration status if not supportedAleksander Morgado
2012-02-17modem: new property to allow specifying longer timeouts when configuring IPAleksander Morgado
This IpTimeout property will be read by NetworkManager, and used as the time to wait for pppd to establish the IP configuration.
2012-02-17iridium: fix operator name and code to be reportedAleksander Morgado
2012-02-17gsm: let plugins override the operator name and code retrievalAleksander Morgado
2012-02-17gsm: allow leading zeroes in numbers in CREG/CGREG responsesAleksander Morgado
2012-02-17generic: only send CGACT if PS network is supportedAleksander Morgado
2012-02-17generic: query PS network registration status only if PS network supported ↵Aleksander Morgado
by the modem
2012-02-17gsm: set pin check flag before requesting ICCID checkAleksander Morgado
2012-02-17gsm: allow no whitespaces before CPIN? reply valueAleksander Morgado
2012-02-17iridium: add initial dummy pluginAleksander Morgado
2012-02-16core: fix loop limits in echo removalAleksander Morgado
-1 was actually correct, if data->len is 10, i goes from 0 to 8.
2012-02-16at-serial-port: implement built-in echo/garbage removalAleksander Morgado
We expect the responses to start always with <CR><LF>. We just remove anything that comes before that.
2012-02-08charsets: don't crash when passing a NULL string to the UTF-8 converterAleksander Morgado
2012-02-07test: fix SMS testcase errors due to uninitialized GErrorDan Williams
2012-02-07gsm: ensure text mode SMS list doesn't pick up too much textDan Williams
This likely has no effect, but just make sure the regex stops grabbing message content when it hits the CF/LF that terminates the message content in text mode.
2012-02-07gsm: fix text mode SMS list regex for single messagesDan Williams
We don't get a \r\n at the end for single messages.
2012-02-07gsm: use new common charset converter when parsing operator name/codeAleksander Morgado
2012-02-07gsm: convert SMS text and number from current charset to UTF-8Aleksander Morgado
2012-02-07charsets: new method to do our best to convert from current charset to UTF-8Aleksander Morgado
This method will try to convert the input string to UTF-8. The input string is supposed to be in the given charset; or otherwise is supposed to be the hex representation of the string in the given charset.
2012-02-07charsets: don't warn if we couldn't convert from hex to utf8Aleksander Morgado
2012-02-07core: plug leaks when passing GValueArrays to dbus_g_method_return()Aleksander Morgado
The ownership of the GValueArray is not transferred.
2012-02-02sms: handle text mode SMS listingDan Williams
Undoubtedly we'll need to adjust the regex but this works for now.
2012-02-01gsm: fix listing SMS messages in text modeDan Williams
Even though we don't parse them correctly yet, at least send the right command for listing them.
2012-02-01gsm: fix setting PDU mode for SMS messagesDan Williams
Stupid signed/unsigned mistake.
2012-02-01core: fix warning about MMModemTime interface initializationDan Williams
The MMModemTime interface was getting initialized more than once.
2012-01-27time: poll for timezoneThomas Tuttle
Signed-off-by: Thomas Tuttle <ttuttle@chromium.org>
2012-01-27time: implement ModemTime in ModemBaseThomas Tuttle
Signed-off-by: Thomas Tuttle <ttuttle@chromium.org>
2012-01-25time: implement MMModemTime boilerplateThomas Tuttle
Signed-off-by: Thomas Tuttle <ttuttle@chromium.org>
2012-01-23core: fix copy & paste errorDan Williams
2012-01-23ussd: ensure coded string is valid before stripping quotesAleksander Morgado
2012-01-23ussd: plug a leakAleksander Morgado
2012-01-18gsm: fix return value of SMS send methodDan Williams
The introspection data specified the Send() method to return an array of unsigned integers, presumably the indexes of the messages just sent. But the code wasn't doing that, leading to a crash when dbus-glib tried to interpret garbage on the return. The problem is that sms_send_auth_cb() gave async_call_done() as the callback for sending the SMS, but that method just calls dbus_g_method_return() with no return arguments. dbus-glib interprets the arguments of dbus_g_method_return() according to the XML introspection data, and thus it was attempting to read the non-existent argument as an 'au' and getting garbage. Fix that by actually returning an array of message indexes from the SMS send code, and propagate that back to the SMS dbus code so it can return something sensible.
2012-01-18gsm: change SMS send validity from 5-minute units to minutesDan Williams
Might as well keep it simple.
2012-01-18gsm: fix CMGS PDU mode length calculationDan Williams
The first byte of the PDU is the SMSC length, but it's not the padded SMSC length. So we need to subtract the actual byte index of the start of the message from length of the PDU, and since the PDU creation function knows all about where the SMSC address stops and the message begins, just have it return that length instead of making the callers calculate it.
2012-01-18gsm: use PDU modem when the modem doesn't support text modeDan Williams
Eventually we should be using PDU mode whenever the modem supports it instead of defaulting to text mode, but there are still some bugs.
2012-01-18tests: add a test for 25-character SMS messagesDan Williams
Tests that the last septet (packed in an octet by itself) doesn't get left off the message like the old code used to do before "core: fix some bugs in GSM7 packing code".
2012-01-18core: fix some bugs in GSM7 packing codeDan Williams
The existing gsm_pack() had a bug where if the last septet should be in an octet by itself, that last octet wouldn't be added. Plus, kinda pointless to use a GByteArray here when we already know what the length will be through simple arithmetic. We can also simplify the function too. Furthermore, there weren't any testcases for starting packing at an offset other than zero, so add one.
2012-01-17gsm: add SMS PDU creation functionDan Williams
Only for basic SMS-SUBMIT PDUs at the moment, and doesn't support large SMSs yet.
2012-01-16core: register SMS errors with dbus-glibDan Williams
2012-01-16serial: handle CMS errors correctlyDan Williams
2012-01-16core: add CMS errorsDan Williams
2012-01-09sms: punt handling of 8-bit encoded SMSs to clientsDan Williams
There's no encoding information about 8-bit SMS messages, and they are often binary things like ringtones or voicemail indicator commands. Since there's no point to our parsing them just let clients deal with it.
2012-01-03cdma: fixes for libqcdm changesDan Williams