| Age | Commit message (Collapse) | Author |
|---|
|
We want to ensure that all errors reported via DBus operations are
normalized to MM-specific errors.
We don't want to return QMI or MBIM specific errors, as those are
protocol specific and we don't want DBus clients to need to rely on
knowing which is the protocol in use by the device.
|
|
|
|
|
|
mm-iface-modem-3gpp-ussd.c: In function ‘interface_disabling_step’:
mm-iface-modem-3gpp-ussd.c:572:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
572 | ctx->step++;
| ~~~~~~~~~^~
..
|
|
mm-iface-modem-3gpp-ussd.c: In function ‘ensure_enabled’:
mm-iface-modem-3gpp-ussd.c:59:5: error: switch missing default case [-Werror=switch-default]
59 | switch (modem_state) {
| ^~~~~~
mm-iface-modem-3gpp-ussd.c: In function ‘interface_disabling_step’:
mm-iface-modem-3gpp-ussd.c:565:5: error: switch missing default case [-Werror=switch-default]
565 | switch (ctx->step) {
| ^~~~~~
mm-iface-modem-3gpp-ussd.c: In function ‘interface_enabling_step’:
mm-iface-modem-3gpp-ussd.c:709:5: error: switch missing default case [-Werror=switch-default]
709 | switch (ctx->step) {
| ^~~~~~
mm-iface-modem-3gpp-ussd.c: In function ‘interface_initialization_step’:
mm-iface-modem-3gpp-ussd.c:831:5: error: switch missing default case [-Werror=switch-default]
831 | switch (ctx->step) {
| ^~~~~~
|
|
|
|
The 'result codes' naming is much more AT-protocol specific, 'events'
is more generic.
|
|
GTask integration will benefit from this change.
|
|
|
|
|
|
|
|
The interfaces usually retrieve objects (e.g. skeletons) from the Modem object
using g_object_get(), but we didn't make sure that these objects were actually
valid before using them.
This should clean up errors happening when the modem gets unplugged and still
some actions are ongoing.
Should fix https://bugzilla.gnome.org/show_bug.cgi?id=685933
|
|
Both the ModemManager daemon and the mmcli will now include `libmm-glib.h' only.
We also handle two new special `_LIBMM_INSIDE_MM' and `LIBMM_INSIDE_MMCLI'
symbols, which if included before the `libmm-glib.h' library allow us to:
* Don't include the libmm-glib high level API in the ModemManager daemon, as
the object names would clash with those in the core.
* Define some of the methods of helper objects to be included only if compiling
ModemManager daemon or the mmcli.
|
|
|
|
|
|
|
|
* mm_base_modem_peek_port_* () will return either a port object (no new
reference), or NULL if none available.
You would usually peek() a port if you're going to use it just in the current
method, as there is no way to that reference to get invalid (we're single
threaded).
* mm_base_modem_get_port_* () will return either NEW references to valid
port objects, or NULL if none available.
And, you would usually get() a port, whenever you want the port object to be
valid even out of the current method, for example when keeping it in the
context of an async operation.
Also, we need to consider that the primary AT port MAY BE NULL when you
peek() or get() it. This is due to the fact that we may be releasing ports
(due to device disconnection) in the middle of async operations.
|
|
Renamed `MMCommonSimpleProperties' to `MMSimpleStatus', and removed the
`MMSimpleStatusProperties' provided in libmm-glib. We'll just use the original
one from libmm-common always.
|
|
|
|
|
|
They will all get it themselves.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
