aboutsummaryrefslogtreecommitdiff
path: root/src/mm-base-call.c
AgeCommit message (Collapse)Author
2018-10-16base-call: no need to delete call info from the deviceAleksander Morgado
Call information only lives in the ModemManager logic, there is no associated date stored within the device itself. Therefore, simplify everything by assuming there is nothing to remove. Looks like this logic was implemented because it was originally based on the SMS management logic, but for SMS we do have to remove them (the stored PDU parts) from the device.
2018-10-16base-call: fix logic when rejecting callsAleksander Morgado
Make sure the async task is always finished, even when mm_base_modem_at_command_finish() returns an error which is not MM_SERIAL_ERROR_RESPONSE_TIMEOUT.
2018-10-16base-call: fix logic when accepting callsAleksander Morgado
Don't return FALSE when call is successfully accepted, otherwise the caller will get very confused: ModemManager[19952]: <debug> [1528968478.344338] (ttyACM2): --> 'ATA<CR>' ModemManager[19952]: <debug> [1528968478.361986] (ttyACM2): <-- '<CR><LF>OK<CR><LF>' (ModemManager:19952): GLib-GIO-CRITICAL **: 11:27:58.387: g_dbus_method_invocation_take_error: assertion 'error != NULL' failed And also, make sure the async task is always finished, even when mm_base_modem_at_command_finish() returns an error which is not MM_SERIAL_ERROR_RESPONSE_TIMEOUT.
2018-06-11call-list: coding style fixesAleksander Morgado
2018-04-24all: drop unused variablesLubomir Rintel
Keeps build with GCC 8 happy. mm-base-call.c:758:18: warning: variable 'response' set but not used [-Wunused-but-set-variable] mm-base-call.c:822:18: warning: variable 'response' set but not used [-Wunused-but-set-variable] mm-base-sms.c:908:18: warning: variable 'response' set but not used [-Wunused-but-set-variable] mm-sms-list.c:331:25: warning: variable 'ctx' set but not used [-Wunused-but-set-variable] mm-iface-modem-messaging.c:1210:21: warning: variable 'storage_ctx' set but not used [-Wunused-but-set-variable] huawei/mm-plugin-huawei.c:183:18: warning: variable 'response' set but not used [-Wunused-but-set-variable] ublox/mm-plugin-ublox.c:161:24: warning: variable 'response' set but not used [-Wunused-but-set-variable] ublox/mm-plugin-ublox.c:159:24: warning: variable 'ctx' set but not used [-Wunused-but-set-variable] icera/mm-modem-helpers-icera.c:218:25: warning: variable 'first_free' set but not used [-Wunused-but-set-variable] novatel/mm-common-novatel.c:50:18: warning: variable 'response' set but not used [-Wunused-but-set-variable]
2017-07-14base-call: minor coding style fixesBen Chan
2017-07-06base-call: port mm_base_call_delete to use GTaskAleksander Morgado
2017-07-06base-call: minor coding style fixesAleksander Morgado
2017-07-06base-call: no need to keep a modem reference aroundAleksander Morgado
The mm_base_modem_at_command() async calls keep a modem reference valid for as long as the operation and its completion handler are run, so there really is no need for the caller (the call operation) to keep a reference to the modem object itself.
2017-07-06base-call: port call_delete to use GTaskBen Chan
2017-07-06base-call: port call_send_dtmf_ready to use GTaskBen Chan
2017-07-06base-call: port call_hangup to use GTaskBen Chan
2017-07-06base-call: port call_accept to use GTaskBen Chan
2017-07-06base-call: port call_start to use GTaskBen Chan
2017-04-08base-call: remove unnecessary string duplicationsBen Chan
2016-08-02base-call: formatting cleanupsDan Williams
2015-08-02core,libmm-glib,cli,voice: Replaced 'SendTone' method and 'ToneReceived' ↵Marco Bascetta
signal with 'SendDtmf' and 'DtmfReceived'
2015-08-02core,voice: minor coding style fixesAleksander Morgado
2015-08-02base-call,iface-modem-voice:: handle DTMFMarco Bascetta
2015-08-02base-call: refactoring of error handling when call startsRiccardo Vangelisti
2015-08-02base-call: created an unique function to switch call's state and reasonRiccardo Vangelisti
2015-08-02base-call: fixed bug when hangup call.Riccardo Vangelisti
Ok, busy and no carrier messages are handled by serial-parser.
2015-08-02base-call: added deletion of a specified callRiccardo Vangelisti
2015-08-02core: implemented new MMBaseCall objectRiccardo Vangelisti