aboutsummaryrefslogtreecommitdiff
path: root/libmm-glib/mm-location-gps-raw.c
AgeCommit message (Collapse)Author
2022-09-05core: port GRegex/GMatchInfo to use autoptr()Aleksander Morgado
The behavior of GRegex changed in 2.73.2 once it was ported from pcre1 to pcre2. In some cases it was made more strict, which is fine, in other cases it exposed some change in how it behaves on certain matches that is not extremely clear whether it's ok or not. See https://gitlab.gnome.org/GNOME/glib/-/issues/2729 See https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/601 See https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/621 Either way, one thing that was assumed was that initializing all GRegex/GMatchInfo variables to NULL and making sure they're NULL before they're initialized by glib (especially the GMatchInfo) was a good and safer approach. So, whenever possible, g_autoptr() is used to cleanup the allocated GMatchInfo/GRegex variables, and otherwise, g_clear_pointer() is used to ensure that no free/unref is attempted unless the given variable is not NULL, and also so that the variable is reseted to NULL after being disposed.
2021-11-16libmm-glib: fix license in sourcesAleksander Morgado
The libmm-glib library is LGPLv2+, not GPLv2+.
2019-10-28libmm-glib: flag as (skip) all non-API methodsAleksander Morgado
So that the GI scanner ignores them.
2019-10-28docs,libmm-glib: provide per-version indicesAleksander Morgado
2018-10-18core: remove unnecessary NULL checks for g_free()Ben Chan
g_free() already check if the given pointer is NULL and does nothing on a NULL pointer.
2018-10-17libmm-glib,gps-raw: prefer $GNGGA over $GPGGAAleksander Morgado
The $GNGGA traces provide "combined" values when multiple satellite constellations are used (e.g. GPS+GLONASS). Prefer these values over the GPS-only $GPGGA traces if both are received.
2018-06-28libmm-glib,location-gps-raw: plug memleakAleksander Morgado
==8663== 1 bytes in 1 blocks are definitely lost in loss record 5 of 4,864 ==8663== at 0x4C2CEDF: malloc (vg_replace_malloc.c:299) ==8663== by 0x669FAC9: g_malloc (in /usr/lib/libglib-2.0.so.0.5600.1) ==8663== by 0x66B9AEA: g_strndup (in /usr/lib/libglib-2.0.so.0.5600.1) ==8663== by 0x66ACE52: g_match_info_fetch (in /usr/lib/libglib-2.0.so.0.5600.1) ==8663== by 0x4E96DD2: mm_location_gps_raw_add_trace (mm-location-gps-raw.c:208) ==8663== by 0x18721E: mm_iface_modem_location_gps_update (mm-iface-modem-location.c:264) ==8663== by 0x1B9C7F: loc_location_nmea_indication_cb (mm-shared-qmi.c:712) ==8663== by 0x640C9E7: g_cclosure_marshal_VOID__BOXEDv (in /usr/lib/libgobject-2.0.so.0.5600.1) ==8663== by 0x6409C95: ??? (in /usr/lib/libgobject-2.0.so.0.5600.1) ==8663== by 0x64259E8: g_signal_emit_valist (in /usr/lib/libgobject-2.0.so.0.5600.1) ==8663== by 0x642612F: g_signal_emit (in /usr/lib/libgobject-2.0.so.0.5600.1) ==8663== by 0x54AAB2D: process_indication (qmi-loc.c:7454) Reported by: Thomas Weißschuh <thomas@weissschuh.net>
2012-11-02libmm-glib: new header file for common stuff in location reportingAleksander Morgado
2012-10-04libmm-glib,location-gps-raw: improve documentationAleksander Morgado
2012-10-04build: merge libmm-common into libmm-glibAleksander Morgado
It's pointless to have libmm-common around, just merge it into libmm-glib and make ModemManager depend on libmm-glib directly. At the end, the non-common stuff in libmm-glib is really minimal.