aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2025-05-08base-sms,sms-list,iface-messaging: move MMBaseSms creation to ↵Dan Williams
MMBroadbandModem class This commit moves creation of the MMBaseSms objects out of MMSmsList and up into MMIfaceModemMessaging (which is already a MMBroadbandModem) and the MMBroadbandModem subclasses themselves. This flattens the creation of MMBaseSms objects by passing them down from the object that creates the SMS parts, rather than having a convoluted callback scheme relying on MMSmsList and MMBaseSms having direct knowledge of their owning modem. The goal is to eventually remove usage of MMBaseModem from MMBaseSms and MMSmsList so that we can test them more easily. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08base-sms,sms-at: split AT-specific SMS code into MMSmsAtDan Williams
Simplify MMBaseSms (making it easier to use from testcases) by splitting the AT-specific code into MMSmsAt rather than keeping it in the base class. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08base-bearer: remove unused includeDan Williams
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08base-sms,iface-modem-messaging: move lock/unlock logic into the interfaceDan Williams
Allows us to test things that rely on MMBaseSms more easily.. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08base-sms: determine 3GPP vs. CDMA at creation timeDan Williams
It won't ever change over the lifetime of the BaseSMS. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08sms-mbim: remove unused codeDan Williams
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08Merge request !1344 from 'cbm-remove-modem'Dan Williams
Begin removing usage of MMBaseModem from leaf classes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1344
2025-05-08base-cbm,cbm-list,iface-cbm: remove usage of MMBaseModemDan Williams
CBM isn't as complicated as SMS, and the CBM class itself doesn't need to be overridden by QMI/MBIM/etc. Now that the log parent and connection binding no longer require MMBaseModem we can flatten the CBM object creation and remove usage of MMBaseModem. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08Move log parent and connection property binding to helperDan Williams
Continues removing usage of MMBaseModem in a bunch of files by splitting out bits of its usage to separate interfaces. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08auth-provider: move auth provider logic into each classDan Williams
Rather than make all of them rely on MMBaseModem for it. This lets us disentangle dependencies for easier unit testing. For interfaces, rather than casting directly to MMBaseModem use intermediate interfaces (MMIfaceAuth and MMIfaceOpLock) that tests can fake out. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08base-modem,auth-provider: move testcase auth bypass to auth providerDan Williams
The bypass when in testcase mode has nothing to do with the base modem class; so make it generic. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08Merge request !1314 from 'quectel-power-down'Dan Williams
quectel: wait for POWERED DOWN URC and decrease other power operation timeouts https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1314
2025-05-08quectel: decrease low-power/power-on/reset wait times to 15 secondsDan Williams
AT docs for many (most?) device state a max timeout of 15 seconds. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08quectel: ensure power down operation waits for POWERED DOWN URCDan Williams
AT docs for many (most?) Quectel devices state that QPOWD=1 receives the OK response very quickly but the caller must wait for the POWERED DOWN URC to avoid data loss. Do that. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08Merge request !1310 from 'disabled-profiles'Dan Williams
bearer: don't choose or activate disabled profiles https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1310
2025-05-08broadband-bearer,modem-helpers: don't use or match disabled profilesDan Williams
When matching profiles ignore disabled ones. When activating a specific profile index, return an error if that profile is marked as disabled. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08broadband-modem-qmi: use correct profile index in error messageDan Williams
Instead of using the loop index, use the actual profile index because they aren't always the same. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08broadband-modem-qmi: implement disabled 3GPP profilesDan Williams
Previously, a disabled profile would cause Profile Manager interface enabling to fail because get_profile_settings_ready() returned an error for disabled profiles. But 3GPP profile objects already have support for the enable/disabled setting, so just hook that up and stop returning an error for disabled ones. This allows successful initialization of the 3GPP Profile Manager on devices that contain disabled profiles. While we're at it, allow creating disabled profiles, and changing profiles back and forth from enabled<->disabled. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08Merge request !1311 from 'sleep-wait'Dan Williams
Wait until device operations complete before dropping suspend inhibitor https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1311 Closes #966
2025-05-08broadband-modem: close serial ports in disposeDan Williams
We want ports to be closed as early as possible; so make sure they are closed in dispose() which is run explicitly by MMDevice when cleaning up and removing the modem. Otherwise they could stay open longer than we want, causing problems for suspend/resume. This caused problems with suspend because cancelling the MMBaseModem's cancellable triggered an idle handler that held a reference to the modem, preventing finalize() from running until after the suspend code was finished, thus preventing ports from being closed and cleaned up. Closing them in dispose() handles this. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-08broadband-modem: remove invalid idle handler during disposeDan Williams
base_modem_invalid_idle() needs to keep a reference to the MMBaseModem until its done. But if the modem is cancelled during removal right before we're trying to forget about it, keeping that reference can prevent everything getting cleaned up by MMBaseModem's dispose() until after the mainloop has run again and all our removal operations are supposedly complete. MMDevice uses an explicit dispose() trigger that mitigates most of this (and requires it for other reasons, like breaking reference cycles between the modem and it's various child classes) but it's somewhat error-prone to keep the modem around if we don't really need to. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-07broadband-modem-qmi,mbim: remove redundant port closesDan Williams
This will just be done immediately after by MMBaseModem's dispose() handler. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-07base-manager: convert shutdown to stepsDan Williams
Make the call flow clearer. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-07base-manager,device: consolidate modem cancelling into mm_device_remove_modem()Dan Williams
Every use of mm_device_remove_modem() was already trying to cancel the modem's canellable, so let's just put it there and simplify the callers. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-07base-manager,sleep-monitor: wait for modem operations before sleepingDan Williams
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-07base-modem: clarify port cleanup/close behavior for serial portsDan Williams
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-07base-modem: allow port teardown operation to use callbacks if neededDan Williams
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-07port-serial: don't log force-closes if not really being forced closeDan Williams
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-07Merge request !1324 from 'nbiot-act'Dan Williams
modem-helpers: report C*REG=2 AcT 9 as NB-IOT access technology https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1324
2025-05-07modem-helpers: report C*REG=2 AcT 9 as NB-IOT access technologyDan Williams
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-01Merge request !1345 from 'reload-reg-after-manual'Dan Williams
broadband-modem: reload registration info after manual registration https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1345 Closes #971
2025-05-01broadband-modem: reload registration info after manual registrationDan Williams
This refreshes operator information after manual registration. QMI and MBIM implementations return operator info along with registration info so they handle this easily, while with AT-based devices we must run additional commands to retrieve that after the manual registration has finished. Suggested by: Kirill Buksha <kirill.buksha@axians.rs> Fixes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/971 Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-05-01Merge request !1343 from 'l10n-sv'Dan Williams
po: Update Swedish translation https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1343
2025-04-25po: Update Swedish translationAnders Jonsson
Signed-off-by: Anders Jonsson <anders.jonsson@norsjovallen.se>
2025-04-25Merge request !1250 from 'probe-allowed-qcdm'Dan Williams
api,modem: new 'IgnoredPorts' property https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1250
2025-04-25fibocom: allow QCDMLukas Voegl
Signed-off-by: Lukas Voegl <lvoegl@tdt.de>
2025-04-25api,modem: new 'IgnoredPorts' propertyLukas Voegl
Expose a new list of 'IgnoredPorts' via D-Bus and therefore remove the use of `MM_MODEM_PORT_TYPE_IGNORED` Signed-off-by: Lukas Voegl <lvoegl@tdt.de>
2025-04-24Merge request !1342 from 'mtk62xx-detect'Dan Williams
broadband-modem: detect old Mediatek 62xx chipsets as GSM-capable https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1342 Closes #980
2025-04-23broadband-modem: detect old Mediatek 62xx chipsets as GSM-capableDan Williams
They don't necessarily reply to +WS46 but like old Motorola ESX devices they reply to +CGMM with a known string. Fixes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/980 Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-04-21Merge request !1335 from 'call-polling'Dan Williams
iface-modem-voice: recheck call state polling when call is started https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1335
2025-04-21iface-modem-voice: recheck call state polling when call is startedDan Williams
When an outgoing call is created and added to the call list its state is UNKNOWN. The call list emits the ADDED signal which MMIfaceModemVoice listens for to check whether to begin polling call state. But since UNKNOWN is not an in-progress call state polling isn't started. And nothing was rechecking whether to start polling when the call state changed to something other than UNKNOWN. Do that so that we can track call progress as it dials out and is answered. Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-04-16Merge request !1338 from 'cinterion-sxrat-assert'Dan Williams
modem-helpers-cinterion: allow spaces in ^SXRAT test response https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1338 Closes #974
2025-04-13modem-helpers-cinterion: allow spaces in ^SXRAT test responseDan Williams
^SXRAT: (0-6), (0,2,3), (0,2,3) Fixes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/974 Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-04-14Merge request !1304 from 'qmi-time-interface'Dan Williams
broadband-modem-qmi: implement Time interface https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1304
2025-04-13broadband-modem-qmi: implement Time interfaceDan Williams
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-04-13Merge request !1337 from 'fibocom-handle-no-fw-parent'Dan Williams
shared-fibocom: don't assume parent implements the firmware interface https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1337 Closes #975
2025-04-13shared-fibocom: don't assume parent implements the firmware interfaceDan Williams
MMBroadbandModemMbimMtkFibocom doesn't, so don't assert it. Fixes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/975 Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-04-13Merge request !1325 from 'cbm/qmi'Dan Williams
broadband-modem-qmi: Add Cell Broadcast support https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1325 Closes #935
2025-04-13broadband-modem-qmi: Enable Cell BroadcastGuido Günther
For QMI we have an extra QMI request so use that to make sure receiving messages is actually enabled. Closes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1325 Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-13broadband-modem-qmi: Add support for loading channelsGuido Günther
This allows to retrive the list of configured Cell Broadcast channels. Closes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1325 Signed-off-by: Guido Günther <agx@sigxcpu.org>
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2025-06-10 09:33:40 +0000