aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-12-06iface-modem-3gpp: Check before registeringSven Schwermer
If the modem is already registered when ModemManager probes the modem, it will ignore the registration state since the modem is not enabled yet. Always querying the registration state before starting the registration procedure makes sure to catch such cases and not perform unnecessary registration steps. Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
2022-12-06broadmobi: add MM_PLUGIN_REQUIRED_QCDM flagClayton Craft
This fixes an issue where, with an BM818 connected over USB, suspending/resuming the modem causes the modem to reset immediately. The culprit was bisected to d6203265c2, where QCDM probing was disabled unless explicitly requested, so I assume this modem needs it based on the constant resetting when power management was enabled on the modem's usb connection.
2022-12-06broadband-modem-mbim: print MbimSmsStatusFlag as flags stringAleksander Morgado
This requires bumping libmbim to 1.29.2, which is the version including the enum->flags change.
2022-12-05broadband-modem-mbim: MbimSmsStatusFlag is flags, not an enumAleksander Morgado
We can directly use this change instead of requiring the libmbim version bump because the numeric values of the enum didn't change: NEW_MESSAGE == 2 == (1<<1) Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/673
2022-11-30base-sms: improve logging of user operationsAleksander Morgado
2022-11-30base-sms: refactor memory management in handlersAleksander Morgado
Use g_auto* helpers where needed, and switch to use the slice allocator for the handler operation contexts.
2022-11-30iface-modem-messaging: improve logging of user operationsAleksander Morgado
2022-11-30iface-modem-messaging: refactor memory management in handlersAleksander Morgado
Use g_auto* helpers where needed, and switch to use the slice allocator for the handler operation contexts.
2022-11-30iface-modem-messaging: use the abort_invocation_if_state_not_reached() helperAleksander Morgado
2022-11-30iface-modem-messaging: allow Delete operation during enabling/disablingAleksander Morgado
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/671
2022-11-28mm-sim-qmi: use UIM service for loading operator identifier and nameAkash Aggarwal
Output of NAS Get Home Network depends on network state, and we may fail to read SIM card info if device is not attached. Load card operator name and identifier using UIM Read Transparent.
2022-11-28cinterion: add retry mechanism to the ^SWWAN? commandHeiko Thiery
Since it is possible that the delayed status request for the connection (^SWWAN?) also does not return the updated status a retry is needed. This retry is only done for the activation path. So the connection status monitoring and the deactivation path is not affected. Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
2022-11-28cinterion: add a delay to the ^SWWAN? commandHeiko Thiery
There are modems where the status in response is not available immediatly. Doing a delayed request will solve the issue. Suggested-by: Giacinto Cifelli <gciofono@gmail.com> Suggested-by: Aleksander Morgado <aleksandermj@chromium.org> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
2022-11-22po: update LINGUAS, add GeorgianNorwayFun
2022-11-22broadband-modem-qmi: don't fail profile update indications setup if one ↵Aleksander Morgado
client missing Using mm_shared_qmi_ensure_client() ensures that the client must exist or otherwise the operation would fail. Instead, try to peek the clients independently with mm_shared_qmi_peek_client() and only fail if both exist. The state machine logic already treats the clients as optional.
2022-11-22mm-broadband-modem-qmi: register for profile change indicationAkash Aggarwal
Update profile manager and notify clients if there is a change in modem profiles list.
2022-11-22broadband-modem-qmi: don't depend on other TLVs when processing Signal InfoAleksander Morgado
When processing the NAS Signal Info message, don't assume that a previously processed TLV creates the MMSignal object for a given access technology.
2022-11-22mm-broadband-modem-qmi: update UMTS RSCP while loading signal valuesAkash Aggarwal
2022-11-22build: require libqmi 1.33.2Aleksander Morgado
For the WCDMA RSCP TLV support.
2022-11-22mm-broadband-modem-qmi: fix Nr5g SNR valueokaestne
value needs to be divided by 10 as for LTE
2022-11-22quectel: add new variant of EM05-G to port type rulesIvan Mikhanchuk
2022-11-21mm-broadband-modem-qmi: fully free SignalLoadValuesResultokaestne
2022-11-15broadband-modem-mbim: add AT based fallback to load model nameSunXinzhao
Modify the load_model function to use the AT command to get the model name and display the module name in the model instead of [vid:pid]. Test on L860 Linux Device, use `mmcli -L`, it can show: "/org/free desktop/ModemManager1/Modem/0 [Intel] L860-GL-16 LTE Module"
2022-11-15mm-broadband-modem-qmi: fix loading Nr5g signal infookaestne
2022-11-15context: include MSG log level in --helpAleksander Morgado
2022-11-11build: unstable release version bump to 1.21.1Aleksander Morgado
2022-11-11fcc-unlock: switch bash shell scripts to use shChristian Taedcke
This enables the usage with busybox and fixes yocto dependency issues. This is related to #483 and the previous commit 91ed72aa29ede06d3a5115128e2267793ca611d4.
2022-11-10test,modem-helpers-qmi: unit tests for NAS system info registration processingAleksander Morgado
Requires the response parser methods in libqmi.
2022-11-10broadband-modem-qmi: use new system info processor helperAleksander Morgado
2022-11-10modem-helpers-qmi: new helper to process System Info messagesAleksander Morgado
2022-11-10modem-helpers: new method to check if reg state is registeredAleksander Morgado
2022-11-10broadband-modem-mbim: simplify caps loading logic by using autoptrAleksander Morgado
2022-11-10broadband-modem-mbim: use ms extensions, if available, for capabilitiesDaniele Palmas
2022-11-10broadband-modem-mbim: add supported modes from CustomDataClassDaniele Palmas
Some modems (e.g. Telit FN990) reports 5G capabilities in CustomDataClass field of device-caps cid: take this into account when building the modes according to the data caps.
2022-11-08iface-modem-3gpp: fix memory leak when processing PCOsAleksander Morgado
==109786== 2,798 (96 direct, 2,702 indirect) bytes in 2 blocks are definitely lost in loss record 5,882 of 5,903 ==109786== at 0x4841888: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==109786== by 0x4A01329: g_malloc (gmem.c:130) ==109786== by 0x4A23F17: g_slice_alloc (gslice.c:1074) ==109786== by 0x4A4B8F8: UnknownInlinedFun (gvariant-core.c:488) ==109786== by 0x4A4B8F8: UnknownInlinedFun (gvariant-core.c:626) ==109786== by 0x4A4B8F8: g_variant_builder_end (gvariant.c:3756) ==109786== by 0x48FD6DC: mm_pco_to_variant (mm-pco.c:251) ==109786== by 0x1AB397: mm_iface_modem_3gpp_update_pco_list (mm-iface-modem-3gpp.c:2274) ==109786== by 0x2306DF: ms_basic_connect_extensions_notification_pco (mm-broadband-modem-mbim.c:5101) ==109786== by 0x2306DF: ms_basic_connect_extensions_notification (mm-broadband-modem-mbim.c:5280) ==109786== by 0x2306DF: device_notification_cb (mm-broadband-modem-mbim.c:5332) ==109786== by 0x4CD3BD6: g_cclosure_marshal_VOID__BOXEDv (gmarshal.c:1686) ==109786== by 0x4CED11B: UnknownInlinedFun (gclosure.c:895) ==109786== by 0x4CED11B: g_signal_emit_valist (gsignal.c:3456) ==109786== by 0x4CED203: g_signal_emit (gsignal.c:3606) ==109786== by 0x50ADA0F: indication_ready (mbim-device.c:870) ==109786== by 0x4B92DD3: g_task_return_now (gtask.c:1232)
2022-11-08bearer-mbim: remove explicit packet service set during attemptAleksander Morgado
An explicit packet service state update request sent during a connection attempt may end up triggering an explicit re-attach with the network, which in turn cancels the ongoing connection attempt. The logic to trigger an explicit attach is now managed by the Simple.Connect() operation, which will make sure that no new request is sent if the modem is already attached, so there is no need for this step in the MBIM connection logic any more. Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/622
2022-11-08broadband-modem-mbim: track uplink/downlink speeds only via indicationsAleksander Morgado
The uplink and downlink speeds will be exclusively tracked via packet service indications, and stored within the MBIM modem object. When the bearer connect result is built, we will include the latest speeds reported, which may have changed upon the operation to connect to the network.
2022-11-08broadband-modem-mbim: translate UNSUPPORTED error during packet attachAleksander Morgado
So that the upper layers are allowed to decide what to do in case the modem doesn't support the operation.
2022-11-08broadband-modem-mbim: return nw_error on packet service attach failureAleksander Morgado
If the packet attach operation fails we may still get the response with a nw_error field telling us a more detailed error reason for the failure. Try to parse the message and return an error including the nw_error information.
2022-11-08broadband-modem-mbim: increase to 30s the packet service set timeoutAleksander Morgado
Same timeout as used in the connection attempt.
2022-11-08iface-modem-simple: explicitly request packet service attach if neededAleksander Morgado
Instead of just waiting for the packet service to be attached, if we waited and still didn't get it, an explicit request will be sent.
2022-11-08iface-modem-3gpp: allow internal request to set packet serviceAleksander Morgado
Provide a new internal method in the 3GPP interface to request an explicit packet service state update.
2022-11-08mm-broadband-modem-mbim: ignore SIM related indications during SIM slot switchJack Song
Using pending_sim_slot_switch_action to ignore SIM slot update during modem shutdown Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/645
2022-11-07TODO: remove obsolete file, we keep pending tasks in gitlabAleksander Morgado
2022-11-07build: drop autotoolsAleksander Morgado
2022-11-07ci: completely switch to mesonAleksander Morgado
2022-11-07build: intel plugin depends on the XMM shared utilsAleksander Morgado
2022-11-07build: disable Test interface in base manager if building without testsAleksander Morgado
There is no real need for this interface if tests are not being built.
2022-11-07build: fix building without tests supportAleksander Morgado
2022-11-07build: fix building without MBIM supportAleksander Morgado
The foxconn shared utils are only built when MBIM is enabled, and therefore the dell and foxconn plugins should only expect those shared utils to be present if MBIM is enabled. The foxconn plugin will be fully disabled when MBIM is disabled. The fibocom shared utils are only built when MBIM is enabled, and therefore the fibocom plugin should not expect them built unconditionally, they will only be present if MBIM is enabled