Age | Commit message (Collapse) | Author |
|
If the modem is already registered when ModemManager probes the modem,
it will ignore the registration state since the modem is not enabled
yet. Always querying the registration state before starting the
registration procedure makes sure to catch such cases and not perform
unnecessary registration steps.
Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
|
|
This fixes an issue where, with an BM818 connected over USB,
suspending/resuming the modem causes the modem to reset immediately.
The culprit was bisected to d6203265c2, where QCDM probing was disabled
unless explicitly requested, so I assume this modem needs it based on
the constant resetting when power management was enabled on the modem's
usb connection.
|
|
This requires bumping libmbim to 1.29.2, which is the version
including the enum->flags change.
|
|
We can directly use this change instead of requiring the libmbim
version bump because the numeric values of the enum didn't change:
NEW_MESSAGE == 2 == (1<<1)
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/673
|
|
|
|
Use g_auto* helpers where needed, and switch to use the slice
allocator for the handler operation contexts.
|
|
|
|
Use g_auto* helpers where needed, and switch to use the slice
allocator for the handler operation contexts.
|
|
|
|
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/671
|
|
Output of NAS Get Home Network depends on network state, and we may fail
to read SIM card info if device is not attached.
Load card operator name and identifier using UIM Read Transparent.
|
|
Since it is possible that the delayed status request for the connection
(^SWWAN?) also does not return the updated status a retry is needed.
This retry is only done for the activation path. So the connection
status monitoring and the deactivation path is not affected.
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
|
|
There are modems where the status in response is not available
immediatly. Doing a delayed request will solve the issue.
Suggested-by: Giacinto Cifelli <gciofono@gmail.com>
Suggested-by: Aleksander Morgado <aleksandermj@chromium.org>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
|
|
|
|
client missing
Using mm_shared_qmi_ensure_client() ensures that the client must exist
or otherwise the operation would fail. Instead, try to peek the
clients independently with mm_shared_qmi_peek_client() and only fail
if both exist.
The state machine logic already treats the clients as optional.
|
|
Update profile manager and notify clients if there is a change in modem
profiles list.
|
|
When processing the NAS Signal Info message, don't assume that a
previously processed TLV creates the MMSignal object for a given
access technology.
|
|
|
|
For the WCDMA RSCP TLV support.
|
|
value needs to be divided by 10 as for LTE
|
|
|
|
|
|
Modify the load_model function to use the AT command to get the
model name and display the module name in the model instead of
[vid:pid].
Test on L860 Linux Device, use `mmcli -L`, it can show: "/org/free
desktop/ModemManager1/Modem/0 [Intel] L860-GL-16 LTE Module"
|
|
|
|
|
|
|
|
This enables the usage with busybox and fixes yocto dependency
issues.
This is related to #483 and the previous commit
91ed72aa29ede06d3a5115128e2267793ca611d4.
|
|
Requires the response parser methods in libqmi.
|
|
|
|
|
|
|
|
|
|
|
|
Some modems (e.g. Telit FN990) reports 5G capabilities in CustomDataClass
field of device-caps cid: take this into account when building the
modes according to the data caps.
|
|
==109786== 2,798 (96 direct, 2,702 indirect) bytes in 2 blocks are definitely lost in loss record 5,882 of 5,903
==109786== at 0x4841888: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==109786== by 0x4A01329: g_malloc (gmem.c:130)
==109786== by 0x4A23F17: g_slice_alloc (gslice.c:1074)
==109786== by 0x4A4B8F8: UnknownInlinedFun (gvariant-core.c:488)
==109786== by 0x4A4B8F8: UnknownInlinedFun (gvariant-core.c:626)
==109786== by 0x4A4B8F8: g_variant_builder_end (gvariant.c:3756)
==109786== by 0x48FD6DC: mm_pco_to_variant (mm-pco.c:251)
==109786== by 0x1AB397: mm_iface_modem_3gpp_update_pco_list (mm-iface-modem-3gpp.c:2274)
==109786== by 0x2306DF: ms_basic_connect_extensions_notification_pco (mm-broadband-modem-mbim.c:5101)
==109786== by 0x2306DF: ms_basic_connect_extensions_notification (mm-broadband-modem-mbim.c:5280)
==109786== by 0x2306DF: device_notification_cb (mm-broadband-modem-mbim.c:5332)
==109786== by 0x4CD3BD6: g_cclosure_marshal_VOID__BOXEDv (gmarshal.c:1686)
==109786== by 0x4CED11B: UnknownInlinedFun (gclosure.c:895)
==109786== by 0x4CED11B: g_signal_emit_valist (gsignal.c:3456)
==109786== by 0x4CED203: g_signal_emit (gsignal.c:3606)
==109786== by 0x50ADA0F: indication_ready (mbim-device.c:870)
==109786== by 0x4B92DD3: g_task_return_now (gtask.c:1232)
|
|
An explicit packet service state update request sent during a
connection attempt may end up triggering an explicit re-attach with
the network, which in turn cancels the ongoing connection attempt.
The logic to trigger an explicit attach is now managed by the
Simple.Connect() operation, which will make sure that no new request
is sent if the modem is already attached, so there is no need for this
step in the MBIM connection logic any more.
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/622
|
|
The uplink and downlink speeds will be exclusively tracked via packet
service indications, and stored within the MBIM modem object.
When the bearer connect result is built, we will include the latest
speeds reported, which may have changed upon the operation to connect
to the network.
|
|
So that the upper layers are allowed to decide what to do in case the
modem doesn't support the operation.
|
|
If the packet attach operation fails we may still get the response
with a nw_error field telling us a more detailed error reason for the
failure. Try to parse the message and return an error including the
nw_error information.
|
|
Same timeout as used in the connection attempt.
|
|
Instead of just waiting for the packet service to be attached, if we
waited and still didn't get it, an explicit request will be sent.
|
|
Provide a new internal method in the 3GPP interface to request an
explicit packet service state update.
|
|
Using pending_sim_slot_switch_action to ignore SIM slot update during modem shutdown
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/645
|
|
|
|
|
|
|
|
|
|
There is no real need for this interface if tests are not being built.
|
|
|
|
The foxconn shared utils are only built when MBIM is enabled, and
therefore the dell and foxconn plugins should only expect those shared
utils to be present if MBIM is enabled. The foxconn plugin will be
fully disabled when MBIM is disabled.
The fibocom shared utils are only built when MBIM is enabled, and
therefore the fibocom plugin should not expect them built
unconditionally, they will only be present if MBIM is enabled
|