aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-14base-bearer: fix check for cancellationLubomir Rintel
If we cancel connect_cancellable, the connect task will return a G_IO_ERROR_CANCELLED. We may need to do some cleanup (like, disconnect if the connection went far enough to actually start the network connection), thus it's important we check for cancellation correctly.
2019-05-14bearer-qmi: remove unused DisconnectContext::dataLubomir Rintel
2019-05-08iface-modem-messaging: flush sms list update before notifying added/removedAleksander Morgado
So that clients are able to have the full updated list before the list update notification.
2019-05-06mmcli: allow use of modem UID to specify SIM operationJohny Mattsson
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/107
2019-05-01mm-broadband-modem: fix error propagation in cdma service statusyparitcher
2019-04-26broadband-modem-mbim: parse nw_error in register_state_set_ready only if ↵Lech Perczak
MBIM_STATUS_FAILURE Some modems (Namely: Telit LE910 V2) report nonzero NwError code, outside of 3GPP TS 24.008 - in "register-state set command-done" response, while status code equals MBIM_STATUS_ERROR_NONE. In such cases network is operational. According to MBIM specification 1.0 table 10.5.9.8 "Status codes", NwError shall be nonzero only if Status Code equals MBIM_STATUS_FAILURE, and client shall parse NwError only in such cases. Also, MBIM specification does not explicitly state that 'NwError == 0' equals no error, rather than that it is unknown error, hence raise an error unconditionally if MBIM status code is MBIM_STATUS_FAILURE. Therefore, check NwError IFF MBIM response status code equals MBIM_STATUS_FAILURE, instead of MBIM_STATUS_SUCCESS. Fixes: 854c371c8aa9 ("broadband-modem-mbim: implement 3GPP registration request") Signed-off-by: Lech Perczak <l.perczak@camlintechnologies.com>
2019-04-25i18n: Added Lithuanian translationMoo
2019-04-15shared-qmi: config list may be emptyAleksander Morgado
Reported by: Enrico Mioso <mrkiko.rs@gmail.com>
2019-04-09shared-xmm: implement support for MSB A-GPSAleksander Morgado
2019-04-09shared-qmi: implement support for MSB A-GPSAleksander Morgado
2019-04-09location,agps: include support for MSB A-GPSAleksander Morgado
2019-04-09iface-modem-location: define first and last location sourcesAleksander Morgado
Much clearer to understand when looping through them.
2019-04-09location,agps: explicitly specify that MSA A-GPS is implementedAleksander Morgado
The A-GPS based implementations we currently have assume MSA A-GPS, so rename the MMModemLocationSource enum value to reflect that.
2019-04-09cli,location: minor refactor to handle the location setup flagsAleksander Morgado
2019-04-09broadband-modem: remove unused CallManagerStateContext defintionBen Chan
2019-04-08altair-lte: remove unused fields in DetailedDisconnectContextBen Chan
2019-04-08plugins,dell: port type hints for the DW5820e moduleAleksander Morgado
2019-04-05build: make compiler warning options compatible with clangBen Chan
This patch updates m4/compiler-warnings.m4 as follows to make it more compatible with clang: * clang doesn't support -Wunused-but-set-variable, which can be replaced with -Wunused-variable as the latter covers unused variables with or without an assigned value and is supported by gcc and clang. * -Wno-unused-function is added to let clang ignore unused functions that are auto-generated.
2019-04-03via: fix memory leak in parent_setup_registration_checks_readyBen Chan
This patch fixes a potential memory leak in parent_setup_registration_checks_ready() where the allocated SetupRegistrationChecksResults may be leaked when the MMIfaceModemCdma parent's setup_registration_checks() fails.
2019-04-03modem-helpers: fix memory leak in mm_3gpp_parse_pdu_cmgl_responseBen Chan
This patch fixes a potential memory leak in mm_3gpp_parse_pdu_cmgl_response() where the allocated MM3gppPduInfo may be leaked when failing to parse the +CMGL response.
2019-04-03ublox: add LISA/SARA-U2 alternative port typesSven Schwermer
When configuring these modems with AT+UUSBCONF=2, i.e. CDC-ECM + 4x CDC-ACM, they also enumerate with a different PID on the USB. We need to adjust the udev rules for that case in order to ignore the non-AT ports. Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
2019-04-02libwmc: remove itDan Williams
The WMC protocol was only present on older Panasonic/Verizon devices from the 2006 - 2011 timeframe. The last device to support WMC was the UML290 which also supported QMI (which is much more functional). ModemManager also never used WMC support and it was never significantly reverse engineered. So remove WMC code from git; it'll still be in the history if anyone cares in the future.
2019-04-02build: fix -Wunused-but-set-variable support and handle clang betterDan Williams
By default the build used -Wno-unused-but-set-variable but that's clearly not what we want. Fix those problems. When using clang, the compiler doesn't error on unknown compile options, so let's add -Werror to the checking too. CC='clang' configure:3408: checking for gcc configure:3435: result: clang ... configure:17644: checking whether gcc understands -Wno-unused-but-set-variable configure:17657: clang -c -Wall -std=gnu89 -g -O2 -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wstrict-prototypes -Wno-unused-parameter -Wno-sign-compare -Wno-deprecated-declarations -Wno-unused-but-set-variable conftest.c >&5 warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Wunknown-warning-option] 1 warning generated. configure:17657: $? = 0 configure:17666: result: yes Reported-by: Torsten Hilbrich <torsten.hilbrich@secunet.com>
2019-04-02shared-qmi: always use newest carrier config if more than one foundAleksander Morgado
2019-04-02shared-qmi: if requested config not installed, fallback to genericAleksander Morgado
If there is a known match for a specific config, but the config is not available in the module, we should fallback to the generic configuration.
2019-04-02shared-qmi: no active carrier config means default is in useAleksander Morgado
In addition to any installed MCFG file, the firmware itself as a 'default' config that will be selected when no carrier config is installed. So it is not an error if 'QMI PDC Get Selected Config' doesn't return the 'Active ID' TLV, it just means the default one is selected.
2019-04-02api,modem: new 'CarrierConfigurationRevision' propertyAleksander Morgado
Which reports the version of the currently active carrier configuration. We also update the firmware 'version' reported in the firmware settings so that carrier-specific upgrades can be performed (e.g. when the firmware stays the same but the MCFG is updated).
2019-04-02firmware: export a device id containing the carrier infoAleksander Morgado
In order to support different per-carrier upgrade paths in fwupd.
2019-04-02plugins,test: setup new simple keyfile testerAleksander Morgado
2019-04-02dell,dw5821e: install carrier config mappingAleksander Morgado
2019-04-02shared-qmi: implement QMI PDC based carrier config supportAleksander Morgado
We implement both loading the current configuration in use, as well as automatically switching to a different one if a mapping file is available.
2019-04-02iface-modem: new carrier config supportAleksander Morgado
During initialization phase we will allow querying the modem for the details of which carrier-specific configuration is being used, and will expose a description string in the API. In addition to showing the current configuration, we will also allow automatically switching the configuration based on the SIM card detected in the device. In order to allow this, plugins/modems will need to provide the expected mapping between carrier config description and MCCMNC. This mapping cannot be generic, because different manufacturers may use different description strings.
2019-04-02broadband-modem-mbim: static array to define used QMI servicesAleksander Morgado
2019-04-02broadband-modem-qmi: static array to define used QMI servicesAleksander Morgado
2019-04-02dell,dw5821e: allow unmanaged GPS even when raw/nmea enabledAleksander Morgado
The raw/nmea GPS source setup is using QMI LOC operations, so there is no point in disallowing the control of the unmanaged GPS source, as the GPS data TTY is exclusively used for unmanaged GPS.
2019-04-02iface-modem-location: allow enabling unmanaged gps even if raw/nmea enabledAleksander Morgado
But only if the plugin implementation allows to do so.
2019-04-02base-manager: fix inhibition alloc/dealloc mixupAleksander Morgado
2019-03-29ublox: fix out-of-bounds array accessesBen Chan
This patch fixes several invalid checks like this: array[i] && i < G_N_ELEMENTS (array) which should instead be: i < G_N_ELEMENTS (array) && array[i] to avoid an out-of-bounds access of the array. Fixes: c1aa658802940327369a6a4cc50d35a4a6a9b04e
2019-03-29ublox: parse +UGCNTRD stats as unsigned 64bit valuesAleksander Morgado
[1551646332.583651] (ttyACM2): --> 'AT+UGCNTRD<CR>' [1551646332.626567] (ttyACM2): <-- '<CR><LF>+UGCNTRD: 1,0,0,0,0<CR><LF><CR><LF>+UGCNTRD: 2,1397316870,113728263578,1397316870,113728263578<CR><LF><CR><LF>OK<CR><LF>' [1551646332.627120] Reloading stats failed: Couldn't load primary PDP context 2 statistics: Error parsing session RX bytes
2019-03-29libmm-glib,common: new helper methods to read guint64 valuesAleksander Morgado
We use strtoull() to read a "unsigned long long" that is always at least 64bits, even in 32bit systems.
2019-03-13ci: run distcheck on default buildAleksander Morgado
2019-03-13ci: include builds without qmi and/or without mbimAleksander Morgado
2019-03-13dell,dw5821e: firmware update support only if QMI is enabledAleksander Morgado
2019-03-03broadband-modem: reorder voice properties after messaging propertiesAleksander Morgado
2019-02-28telit: add Telit MBIM broadband modemDaniele Palmas
Modes and band support are added through AT commands.
2019-02-28telit: move shared functions to mm-shared-telitDaniele Palmas
2019-02-26dell,dw5821e: use DMS extension method to load properly formatted firmware ↵Aleksander Morgado
version And require libqmi 1.23.1.
2019-02-22port-qmi: increase qmi_device_open retriesDaniele Palmas
Telit modems LM940/960 need more time for becoming responsive to qmi requests after device appearance.
2019-02-15broadband-modem-qmi: log reason of QMI port open failureBeniamino Galvani
If ModemManager fails to open a QMI port with data format update, it retries without update. It would be useful to log the reason why the first try failed; for example on RHEL 7.6 ModemManager fails to write to sysfs due to SELinux. With this commit, the following message would be logged: <debug> QMI port open operation finished <debug> Couldn't open QMI port with data format update: Expected data format not updated properly: Failed to open file '/sys/class/net/wwp0s29u1u2i8/qmi/raw_ip' for R/W: Permission denied <debug> Opening QMI device... instead of just: <debug> QMI port open operation finished <debug> Opening QMI device... While at it, also fix the GError leak.
2019-02-14Add .gitlab-ci.ymlEric Caruso
This allows us to run unit tests on every commit to the gitlab instance.