aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-11base-call: implement Deflect() with +CTFRAleksander Morgado
2019-07-11api,call: new Deflect() methodAleksander Morgado
This method allows deflecting an incoming or waiting call to a different number.
2019-07-11broadband-modem: implement Transfer() with +CHLD=4Aleksander Morgado
2019-07-11api,voice: new Transfer() methodAleksander Morgado
This method will join all active and held calls into a single multiparty call, and then request the network to terminate the call on the subscriber's end and transfer the control of the call to the parties that are still in the call.
2019-07-11broadband-modem: implement HangupAll() with +CHUPAleksander Morgado
2019-07-11api,voice: new HangupAll() methodAleksander Morgado
This method will terminate all ongoing calls.
2019-07-11broadband-modem: implement HoldAndAccept() with +CHLD=2Aleksander Morgado
2019-07-11api,voice: new HoldAndAccept() methodAleksander Morgado
This method will put the currently active call on hold, and right away accept the next available call. The user of the API does not need to specify explicitly which is the next call to accept, because that is decided automatically: * If there is any waiting call, it will accept it right away. * If there is no waiting call but there is a held call, it will make the held call active again.
2019-07-11broadband-modem: implement HangupAndAccept() with +CHLD=1Aleksander Morgado
2019-07-11api,voice: new HangupAndAccept() methodAleksander Morgado
This method will hangup the currently active call and right away accept the next available call. The user of the API does not need to specify explicitly which is the next call to accept, because that is decided automatically: * If there is any waiting call, it will accept it right away. * If there is no waiting call but there is a held call, it will make the held call active again.
2019-07-11base-call: support hanging up specific callsAleksander Morgado
E.g. we can hangup a waiting call without interfering with the active one.
2019-07-11broadband-modem: implement call list polling with +CLCCAleksander Morgado
2019-07-11cinterion: disable call list polling if ^SLCC is supportedAleksander Morgado
Early detect that ^SLCC is supported, and disable the call list polling in the interface if so.
2019-07-11iface-modem-voice: setup full call list polling logicAleksander Morgado
If the modem supports call list polling, we'll setup a timeout to poll for the full call list periodically, in order to get detailed call states. The timeout is setup as soon as a new call is created, and it will be kept enabled as long as there is a call being established (i.e. not unknown, not terminated, not active).
2019-07-11cinterion: when ^SLCC is supported, detailed call state updates are implicitAleksander Morgado
2019-07-11broadband-modem: if +CLCC is supported, call supports detailed eventsAleksander Morgado
2019-07-11cinterion: support ^SLCC URCs as part of voice managementAleksander Morgado
This command will give us URCs whenever the extended list of current calls changes, which includes information about the actual state of each call, even for calls in waiting state. Therefore, as this is a URC that applies to all calls, it's enabled and disabled as part of the modem voice interface, instead of doing it as part of the call object itself (i.e. not treated as an in-call URC).
2019-07-11cinterion: implement resetAleksander Morgado
2019-07-11cinterion: port type hints for the PLS8Aleksander Morgado
The first two ports are AT control ports (application/modem). We rely on AT^SQPORT to decide which one is which. The last two ports are unknown and we explicitly ignore them to make port probing much quicker.
2019-07-11iface-modem-voice: allow reporting the state of all ongoing callsAleksander Morgado
E.g. as per the AT+CLCC output.
2019-07-11helpers: new '+CLCC' test response parserAleksander Morgado
2019-07-11base-call: if incoming call is reported terminated, cleanup timeoutAleksander Morgado
2019-07-11base-call: allow skipping the timeout in incoming callsAleksander Morgado
E.g. if the modem supports reporting incoming call updates explicitly.
2019-07-11base-call: allow keeping ongoing call index for easy call matchingAleksander Morgado
2019-07-11base-call: add simple getters for the MmGdbusCall propertiesAleksander Morgado
2019-07-11call-list: allow iterating elementsAleksander Morgado
2019-07-11broadband-modem: implement +CCWA URC handlingAleksander Morgado
2019-07-11iface-modem-voice: allow creating incoming calls in waiting stateAleksander Morgado
2019-07-11broadband-modem,voice: enable/disable call waiting indicationsAleksander Morgado
2019-07-11broadband-modem,voice: disable unsolicited eventsAleksander Morgado
2019-07-11broadband-modem,voice: rework enabling of unsolicited eventsAleksander Morgado
The previous logic would end up returning an error if either +CLIP or +CRC reported an error, and we should really avoid that, because our setup is able to manage the voice calls even without those settings. So, convert the logic into a small state machine and try to configure the settings both in the primary and secondary ports, instead of just in the primary one.
2019-07-11docs: add missing MMCallStateReason documentationAleksander Morgado
2019-07-11docs: add missing MMCallDirection documentationAleksander Morgado
2019-07-11docs: add missing short description for compat sectionAleksander Morgado
2019-07-11docs: add missing MM_CHECK_VERSION documentationAleksander Morgado
2019-07-10misc: use g_regex_match() for simplicityBen Chan
This CL converts a few g_regex_match_full() expressions to their equivalent g_regex_match() in order to simplify the code, i.e. g_regex_match_full (regex, str, strlen (str), 0, 0, &match_info, NULL) is equivalent to: g_regex_match_full (regex, str, -1, 0, 0, &match_info, NULL) or simply: g_regex_match (regex, str, 0, &match_info)
2019-07-09base-sms: wait up to 60s when sending SMS messagesAleksander Morgado
The operation sending the raw data of the SMS may timeout because the current value of 10s is too low. When this happens, we may end up marking the modem as invalid if the operation takes much longer, as in https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/133 <debug> [1561707204.192676] (ttyUSB3): --> 'AT+CMGS=22<CR>' <debug> [1561707204.207212] (ttyUSB3): <-- '<CR><LF>> ' <debug> [1561707204.207562] (ttyUSB3) device open count is 3 (open) <debug> [1561707204.207695] (ttyUSB3) device open count is 2 (close) <debug> [1561707204.207841] (ttyUSB3): --> '0021000B9164xxxxxxxxFx00000AEDF6989D06D1CB733A\26' <debug> [1561707204.261028] (ttyUSB3): <-- '<CR><LF>' <debug> [1561707205.197464] (ttyUSB3) device open count is 3 (open) <debug> [1561707207.197763] loading signal quality... <debug> [1561707207.197990] (ttyUSB3) device open count is 4 (open) <debug> [1561707210.199337] (ttyUSB3) device open count is 5 (open) <debug> [1561707214.197198] (ttyUSB3) device open count is 4 (close) <debug> [1561707214.197443] (ttyUSB3): --> 'AT+CGACT?<CR>' <debug> [1561707215.196530] (ttyUSB3) device open count is 5 (open) <warn> [1561707217.196750] checking if connected failed: Couldn't check current list of active PDP contexts: Serial command timed out <debug> [1561707217.196928] (ttyUSB3) device open count is 4 (close) <warn> [1561707217.197065] (tty/ttyUSB3) at port timed out 2 consecutive times <debug> [1561707217.197187] (ttyUSB3): --> 'AT+CIND?<CR>' <debug> [1561707220.198180] (ttyUSB3) device open count is 5 (open) <debug> [1561707222.196792] (ttyUSB3) device open count is 6 (open) <debug> [1561707222.196983] (ttyUSB3) device open count is 5 (close) <warn> [1561707222.197125] (tty/ttyUSB3) at port timed out 3 consecutive times <debug> [1561707222.197257] (ttyUSB3): --> 'AT+CGACT?<CR>' <debug> [1561707225.198384] (ttyUSB3) device open count is 6 (open) <warn> [1561707225.198616] checking if connected failed: Couldn't check current list of active PDP contexts: Serial command timed out <debug> [1561707225.198703] (ttyUSB3) device open count is 5 (close) <warn> [1561707225.198814] (tty/ttyUSB3) at port timed out 4 consecutive times <debug> [1561707225.199437] (ttyUSB3): --> 'AT+CGACT?<CR>' <warn> [1561707228.196747] checking if connected failed: Couldn't check current list of active PDP contexts: Serial command timed out <debug> [1561707228.196915] (ttyUSB3) device open count is 4 (close) <warn> [1561707228.197050] (tty/ttyUSB3) at port timed out 5 consecutive times <debug> [1561707228.197175] (ttyUSB3): --> 'AT+CGACT?<CR>' <debug> [1561707230.197709] (ttyUSB3) device open count is 5 (open) <warn> [1561707231.197089] checking if connected failed: Couldn't check current list of active PDP contexts: Serial command timed out <debug> [1561707231.197256] (ttyUSB3) device open count is 4 (close) <warn> [1561707231.197387] (tty/ttyUSB3) at port timed out 6 consecutive times <debug> [1561707231.197519] (ttyUSB3): --> 'AT+CSQ<CR>' <debug> [1561707234.199671] Couldn't refresh signal quality: 'Serial command timed out' <debug> [1561707234.199897] (ttyUSB3) device open count is 5 (open) <debug> [1561707234.200038] (ttyUSB3) device open count is 4 (close) <warn> [1561707234.200161] (tty/ttyUSB3) at port timed out 7 consecutive times <debug> [1561707234.200291] (ttyUSB3): --> 'AT+CGACT?<CR>' <debug> [1561707235.197071] (ttyUSB3) device open count is 5 (open) <debug> [1561707237.198460] Signal quality value not updated in 60s, marking as not being recent <warn> [1561707237.198846] checking if connected failed: Couldn't check current list of active PDP contexts: Serial command timed out <debug> [1561707237.198949] (ttyUSB3) device open count is 4 (close) <warn> [1561707237.199060] (tty/ttyUSB3) at port timed out 8 consecutive times <debug> [1561707237.199636] (ttyUSB3): --> 'AT+CGACT?<CR>' <debug> [1561707240.198778] (ttyUSB3) device open count is 5 (open) <warn> [1561707240.199031] checking if connected failed: Couldn't check current list of active PDP contexts: Serial command timed out <debug> [1561707240.199127] (ttyUSB3) device open count is 4 (close) <warn> [1561707240.199244] (tty/ttyUSB3) at port timed out 9 consecutive times <debug> [1561707240.199363] (ttyUSB3): --> 'AT+CNSMOD?<CR>' <debug> [1561707243.198163] Couldn't refresh access technologies: 'Serial command timed out' <debug> [1561707243.198294] Periodic signal quality checks scheduled in 30s <debug> [1561707243.198402] (ttyUSB3) device open count is 3 (close) <error> [1561707243.198528] (tty/ttyUSB3) at port timed out 10 consecutive times, marking modem '/org/freedesktop/ModemManager1/Modem/0' as invalid <debug> [1561707243.198699] (ttyUSB3): --> 'AT+CGACT?<CR>' Or we may end up aborting other actions that the modem is doing... <debug> [1560473069.956036] (ttyACM2): --> 'AT+CMGS=70<CR>' <debug> [1560473069.963667] Added CALL at '/org/freedesktop/ModemManager1/Call/1' <debug> [1560473069.977937] (ttyACM2): <-- '<CR><LF>> ' <debug> [1560473069.978558] (ttyACM2) device open count is 3 (open) <debug> [1560473069.978812] (ttyACM2) device open count is 2 (close) <debug> [1560473069.979152] (ttyACM2): --> '0001000D8......................\26' <debug> [1560473080.317049] (ttyACM2): --> 'ATD123456789;<CR>' <debug> [1560473092.293458] (ttyACM2): <-- '<CR><LF>+CMGS: 1<CR><LF><CR><LF>OK<CR><LF>' <warn> [1560473092.293854] Couldn't start call : 'Couldn't start the call: Unhandled response '+CMGS: 1'' <info> [1560473092.293936] Call state changed: dialing -> terminated (unknown) <debug> [1560473092.293987] Cleaning up in-call unsolicited events... So, update the raw data sending timeout to a much longer value.
2019-07-02docs: add deprecated items to sections fileAleksander Morgado
2019-07-02api,location: fix A-GPS MSA/MSB documentation linksAleksander Morgado
2019-07-02po: Add zh_CN translationwi24rd
2019-06-28introspection,voice: fix documentation of CallAdded() signalAleksander Morgado
2019-06-28modem-helpers: ignore format of unneeded fields in +CLIP URCAleksander Morgado
The regex was expecting empty values in several of the fields, which is wrong. Instead of matching empty fields, just ignore all fields that we don't require in our logic.
2019-06-28broadband-modem: fix logging whether enabling or disabling URCsAleksander Morgado
2019-06-24iface-modem-3gpp: use correct finish() method to complete user registrationAleksander Morgado
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/131
2019-06-13cinterion: make custom +CIEV parser much more genericAleksander Morgado
The custom +CIEV parser configured for Cinterion modems was exclusively matching the "psinfo" indicator updates, which were the ones really used afterwards. But, in order to avoid having undesired URCs mixed with other command responses, we should anyway match any +CIEV indicator reported, not only "psinfo". The text indicator ids used in +CIEV seem to bee specific to Cinterion devices when they're configured via AT^SIND, so we do a generic match for any lowercase ascii text as indicator id.
2019-06-13ublox,tests: expect error if empty band list when parsing UACT?Aleksander Morgado
2019-06-13ublox: return error when no bands are parsedAleksander Morgado
If load_current_bands_finish() returns a NULL GArray, we must set the GError or otherwise the daemon will segfault when the caller dereferences the GError: current_bands = MM_IFACE_MODEM_GET_INTERFACE (self)->load_current_bands_finish (self, res, &error); if (!current_bands) { /* Errors when getting current bands won't be critical */ mm_warn ("couldn't load current Bands: '%s'", error->message); g_error_free (error); } This may happen with an empty but balid +UACT response, e.g.: AT+UACT? +UACT: ,,, OK Or when it replies a full empty string: AT+UACT? OK
2019-06-11modem-helpers: minor coding style fixesAleksander Morgado
2019-06-03port-serial-at: raw commands always run nextAleksander Morgado
We use the raw commands exclusively when we're sending SMS data to the device. Until this change, all raw commands were added at the tail of the queue of pending commands, and that meant that if any unrelated AT command was interleaved between e.g. our AT+CGMS and the actual SMS data sent, the operation would have failed. With this fix, we're making sure that all raw commands are added at the head of the queue, so we're making sure that the next command picked after e.g. CGMS is actually the raw SMS data to be sent. We would be avoiding issues like this one, where an outgoing voice call attempt gets in the way before we send the SMS data: [1556246081.786284] (ttyACM2): --> 'AT+CMGS=70<CR>' [1556246081.814861] (ttyACM2): <-- '<CR><LF>> ' [1556246081.819382] (ttyACM2): --> 'ATD1234567890;<CR>' [1556246081.839685] (ttyACM2): <-- '<CR><LF>> ' [1556246081.840123] Couldn't start call : 'Couldn't start the call: Unhandled response '> '' [1556246081.856254] (ttyACM2): --> '0001000D810.............. [1556246081.922470] (ttyACM2): <-- '<CR><LF>+CME ERROR: 4<CR><LF>'
2019-06-03port-serial: allow deciding whether the command is queued last or run nextAleksander Morgado
By default all the commands we were sending through the serial port were added at the tail of the pending queue, but we may want to queue them at the head in very specific cases (e.g. while sending an SMS).
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2025-06-13 06:57:39 +0000