aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-08-08broadband-modem-qmi: check MDN set after manual activationAleksander Morgado
2013-08-08broadband-modem-qmi: implement manual CDMA activationAleksander Morgado
We'll also now require libqmi 1.5 (git master), needed to handle the PRL TLV in 'DMS Activate Manual'. TODO: require 1.6 as soon as it is released.
2013-08-08mmcli,cdma: new '--cdma-activate-manual' actionAleksander Morgado
Along with a new '--cdma-activate-manual-with-prl'. These can be used to request CDMA Manual Activation, like: $> sudo mmcli \ -m 0 \ --cdma-activate-manual="spc=123456,sid=ab,mdn=0123456789abcde,min=0123456789abcde" Or: $> sudo mmcli \ -m 0 \ --cdma-activate-manual="spc=123456,sid=ab,mdn=0123456789abcde,min=0123456789abcde" \ --cdma-activate-manual-with-prl=/path/to/my/prl.data
2013-08-08libmm-glib,cdma: implement manual activation methodsAleksander Morgado
2013-08-08iface-modem-cdma: use the new 'MMCdmaManualActivationProperties'Aleksander Morgado
2013-08-08libmm-glib: new 'MMCdmaManualActivationProperties' helper objectAleksander Morgado
2013-08-08introspection,api: document the expected parameters in Cdma.ActivateManual()Aleksander Morgado
2013-08-06modem-helpers: fix parsing of CREG/CGREG/CEREG responsesBen Chan
The format of CREG/CGREG/CEREG responses is not very precisely defined in or strictly enforced by the 3GPP specifications. That leads to the fact that some modems put leading zeros in integer type fields (e.g. <n>, <stat>, <AcT>), and not all modems put double quotes around string type fields (e.g. <lac>, <ci>) in those C*REG responses. For example, 0001 can be a valid value for both <stat> and <lac>. The original C*REG parsing code in ModemManager could potentially interpret '+CREG: <stat>,<lac>,<ci>,<AcT>' as '+CREG: <n>,<stat>,<lac>,<ci>'. This patch addresses this issue by refining the regular expressions returned by mm_3gpp_creg_regex_get() with the following assumptions: 1. If a modem puts leading zeros in integer type fields, it puts double quotes around string type fields. 2. If a modem omits double quotes around string type fields, it does not put leading zeros in integer type fields.
2013-08-06huawei: ignore ^PDPDEACT unsolicited messagesBen Chan
2013-08-06huawei: handle whitespace in RSSI responsesBen Chan
This patch modifies the regular expressions for parsing ^RSSI, ^RSSILVL, and ^HRSSILVL responses to handle any whitespace that is inserted between the colon and the RSSI value. The issue is identified by Dan Williams <dcbw@redhat.com>
2013-08-05huawei: implement modem power up and downBen Chan
This patch is originally developed by: Franko Fang <fangxiaozhi@huawei.com> And then reviewed and updated by: Ben Chan <benchan@chromium.org>
2013-07-31huawei: reset disconnect_pending to NULL when ^NDISSTATQRY failsBen Chan
2013-07-23serial: add logging to serial port open failuresDan Williams
2013-07-23build: fix dbus activation file generationAleksander Morgado
https://bugzilla.gnome.org/show_bug.cgi?id=704711
2013-07-19build: post release version bump to 1.1.0 (development)Aleksander Morgado
2013-07-19release: bump version to 1.0.0Aleksander Morgado
2013-07-19release: update NEWSAleksander Morgado
2013-07-19docs: update migration reference version numberAleksander Morgado
2013-07-19api,introspection: update interface version numberAleksander Morgado
2013-07-18broadband-modem-qmi: plug memleak when listing SMS messagesAleksander Morgado
2013-07-18libmm-glib,firmware-properties: allow NULL when building dictionaryAleksander Morgado
2013-07-17sms: initialize 'validity' property always to a defaultAleksander Morgado
When we're exposing not-yet-completed multipart messages, we need to provide a correct value for the validity property, or gdbus may crash, see e.g.: https://bugzilla.gnome.org/show_bug.cgi?id=704319
2013-07-15mmcli,messaging: plug memleakAleksander Morgado
2013-07-14altair-lte: set serial port send delay to 0Ben Chan
With a non-zero send delay, the communication over the ttyACM port of the modem is not very stable when USB auto-suspend is enabled for the modem. The send delay is not necessary and thus removed by this patch. Ori Inbar <ori.inbar@altair-semi.com> reported the issue and suggested this fix.
2013-07-14build: require libmbim by default, and explicitly log about --without-mbimAleksander Morgado
2013-07-14build: explicitly log about --without-qmi when looking for libqmi failsAleksander Morgado
2013-07-12sms-properties: fix introspection commentAleksander Morgado
2013-07-11build: fix multiply defined EXTRA_DISTDan Williams
plugins/Makefile.am:375: warning: EXTRA_DIST multiply defined in condition TRUE ... gtester.make:6: ... 'EXTRA_DIST' previously defined here plugins/Makefile.am:1: 'gtester.make' included from here
2013-07-11huawei: use ^NDISSTATQRY to check for connection statusAleksander Morgado
Patch based on changes from Franko Fang <fangxiaozhi@huawei.com>.
2013-07-11huawei: new helper to parse ^NDISSTATQRY responsesAleksander Morgado
2013-07-11broadband-modem-qmi: fix incorrect conversions from double to gint32Ben Chan
This patch fixes the following incorrect conversions from double to gint32: mm-broadband-modem-qmi.c:4785:27: error: implicit conversion from 'double' to 'gint32' (aka 'int') changes value from 2.225073858507201E-308 to 0 [-Werror,-Wliteral-conversion] gint32 bs_longitude = MM_LOCATION_LONGITUDE_UNKNOWN; ~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm-broadband-modem-qmi.c:4786:26: error: implicit conversion from 'double' to 'gint32' (aka 'int') changes value from 2.225073858507201E-308 to 0 [-Werror,-Wliteral-conversion] gint32 bs_latitude = MM_LOCATION_LATITUDE_UNKNOWN; ~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2013-07-11modem-helpers-qmi: fix enumeration type mismatchesBen Chan
This patch fixes the following enumeration type mismatches: mm-modem-helpers-qmi.c:980:12: error: implicit conversion from enumeration type 'QmiNasRatModePreference' to different enumeration type 'QmiNasRadioTechnologyPreference' [-Werror,-Wenum-conversion] return qmi; ~~~~~~ ^~~ mm-modem-helpers-qmi.c:1082:12: error: implicit conversion from enumeration type 'MMModemMode' to different enumeration type 'QmiNasGsmWcdmaAcquisitionOrderPreference' [-Werror,-Wenum-conversion] return MM_MODEM_MODE_NONE; ~~~~~~ ^~~~~~~~~~~~~~~~~~ mm-modem-helpers-qmi.c:1096:16: error: implicit conversion from enumeration type 'QmiNasRegistrationState' to different enumeration type 'MMModem3gppRegistrationState' [-Werror,-Wenum-conversion] return QMI_NAS_REGISTRATION_STATE_NOT_REGISTERED; ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2013-07-10x22x: add support for Olivetti Olicard 200Dan Williams
2013-07-08docs,libmm-glib: update type informationAleksander Morgado
2013-07-08serial-port: warn if ioctl(TIOCSSERIAL) fails to set closing_waitBen Chan
Prints out a warning if ioctl(TIOCSSERIAL) fails to set closing_wait to none. This helps debug issues when a serial driver does not support or properly handle closing_wait, which may cause closing of the serial port to block.
2013-07-04altair-lte: support load_power_state in MMIfaceModemBen Chan
Being able to determine the current power state of the modem is necessary to ensure reliable modem operations.
2013-06-28altair-lte: propagate error when load_{supported,current}_bands failsBen Chan
This patch fixes a potential crash when MMIfaceModem::load_current_bands_ready() dereferences a NULL GError pointer, which happens when the altair-lte plugin fails to load the current bands but does not propagate the error. It also fixes a similar issue with the plugin fails to load the supported bands, even though MMIfaceModem::load_supported_bands_ready() checks for a NULL GError pointer.
2013-06-28novatel-lte: propagate error when load_current_bands failsBen Chan
This patch fixes the following crash when MMIfaceModem::load_current_bands_ready() dereferences a NULL GError pointer, which happens when the novatel-lte plugin fails to load the current bands but does not propagate the error. Thread 0 *CRASHED* ( SIGSEGV @ 0x00000000 ) 0x7f04d6c89c36 [ModemManager] - mm-iface-modem.c:3886 load_current_bands_ready 0x7f04d6942236 [libgio-2.0.so.0.3200.4] - gsimpleasyncresult.c:767 g_simple_async_result_complete 0x7f04d6942338 [libgio-2.0.so.0.3200.4] - gsimpleasyncresult.c:779 complete_in_idle_cb 0x7f04d67fad74 [libglib-2.0.so.0.3200.4] - gmain.c:2539 g_main_context_dispatch 0x7f04d67fb0f7 [libglib-2.0.so.0.3200.4] - gmain.c:3146 g_main_context_iterate 0x7f04d67fb551 [libglib-2.0.so.0.3200.4] - gmain.c:3340 g_main_loop_run 0x7f04d6c68795 [ModemManager] - main.c:142] main 0x7f04d6213464 [libc-2.15.so] - libc-start.c:234] __libc_start_main 0x7f04d6c68318 [ModemManager] + 0x0001d318]
2013-06-27man,mmcli: changing modes and bands no longer allowed in '--simple-connect'Aleksander Morgado
2013-06-27altair-lte: avoid sending ATZ when enabling the modemBen Chan
This patch prevents an ATZ command, which causes the modem to reboot, from being sent to the modem when the modem is being enabled.
2013-06-26plugin-manager: handle modems where only some ports report being IceraAleksander Morgado
Icera-based Nokia modems may reply correctly to the Icera probing only in some AT ports, not in all. In order to handle this situation we override the final plugin selected to be the Icera-based one if we find that the mismatched plugins have the 'icera-allowed' and 'icera-forbidden' filters. https://bugzilla.gnome.org/show_bug.cgi?id=703022
2013-06-26icera: load supported modes with AT%IPSYS=?Aleksander Morgado
http://bugzilla.gnome.org/show_bug.cgi?id=703023
2013-06-25systemd: schedule to restart the service on-abortAleksander Morgado
See https://bugzilla.gnome.org/show_bug.cgi?id=701229.
2013-06-25iface-modem: plug memleakAleksander Morgado
2013-06-25serial-parsers: plug memleakAleksander Morgado
2013-06-24broadband-bearer-hso: IPv4 prefix is always /32Dan Williams
The modem doesn't give us a prefix in the OWANDATA response, but it's always /32. This didn't get set previously because NetworkManager always just used /32 for the 'static' configuration, but NM isn't the only user of MM, and only MM knows for sure that the prefix should be /32.
2013-06-24api,introspection: new 'Ports' property in the Modem interfaceAleksander Morgado
We will expose a new 'Ports' property listing all ports currently known by a given modem. Ports which are not used but are detected as being part of the modem will be listed with an 'unknown' port type. This change uses the new 'MMModemPortType' enum and the new 'MMModemPortInfo' helper struct to handle these values in libmm-glib. The already available 'MMPortType' enum hasn't been re-used for the interface because it contains values that we don't need (e.g. IGNORED). The port list is now also included in the modem information command of mmcli: $ sudo mmcli -m 0 /org/freedesktop/ModemManager1/Modem/0 (device id '97b7b99e3e2bea103880545b619fb05a3cc81b26') ------------------------- System | device: '/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.4' | drivers: 'qcserial, qmi_wwan' | plugin: 'Gobi' | primary port: 'cdc-wdm0' | ports: 'ttyUSB0 (qcdm), ttyUSB1 (at), cdc-wdm0 (qmi), wwp0s29u1u4 (net)' https://bugzilla.gnome.org/show_bug.cgi?id=702678
2013-06-24hso: if IPv6 bearer type requested, create a generic bearerAleksander Morgado
Option/HSO modems don't seem to support IPv6 when using the net interface. So if IPv6 is requested, create a generic bearer. $ sudo mmcli -m 0 --simple-connect="apn=internet,ip-type=ipv6" successfully connected the modem $ sudo mmcli -b 0 Bearer '/org/freedesktop/ModemManager1/Bearer/0' ------------------------- Status | connected: 'yes' | suspended: 'no' | interface: 'ttyHS3' | IP timeout: '20' ------------------------- Properties | apn: 'internet' | roaming: 'allowed' | IP type: 'ipv6' | user: 'none' | password: 'none' | number: 'none' | Rm protocol: 'unknown' ------------------------- IPv4 configuration | method: 'ppp' ------------------------- IPv6 configuration | method: 'unknown' $ sudo mmcli -m 0 --simple-disconnect successfully disconnected all bearers in the modem https://bugzilla.gnome.org/show_bug.cgi?id=702472
2013-06-24iface-modem: don't rely on the cached current power state valueAleksander Morgado
The real power state value of the modem may be changed by other means, e.g. rfkill. So when changing power state of the modem in MM, we better recheck which the current power status is. A better full approach would be to follow rfkill changes, but this fix should help until that is done. https://bugzilla.gnome.org/show_bug.cgi?id=702838
2013-06-24mmcli: SMS class value is a signed integer, not unsigedAleksander Morgado