aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--plugins/telit/tests/test-mm-modem-helpers-telit.c46
1 files changed, 35 insertions, 11 deletions
diff --git a/plugins/telit/tests/test-mm-modem-helpers-telit.c b/plugins/telit/tests/test-mm-modem-helpers-telit.c
index ef257441..e6bff0bc 100644
--- a/plugins/telit/tests/test-mm-modem-helpers-telit.c
+++ b/plugins/telit/tests/test-mm-modem-helpers-telit.c
@@ -316,10 +316,11 @@ test_common_bnd_cmd (const gchar *expected_cmd,
#define test_common_bnd_cmd_4g(EXPECTED_CMD, BANDS_ARRAY) test_common_bnd_cmd (EXPECTED_CMD, FALSE, FALSE, TRUE, FALSE, BANDS_ARRAY)
static void
-test_common_bnd_cmd_invalid (gboolean modem_is_2g,
- gboolean modem_is_3g,
- gboolean modem_is_4g,
- GArray *bands_array)
+test_common_bnd_cmd_error (gboolean modem_is_2g,
+ gboolean modem_is_3g,
+ gboolean modem_is_4g,
+ GArray *bands_array,
+ MMCoreError expected_error)
{
gchar *cmd;
GError *error = NULL;
@@ -328,13 +329,16 @@ test_common_bnd_cmd_invalid (gboolean modem_is_2g,
modem_is_2g, modem_is_3g, modem_is_4g,
FALSE,
&error);
- g_assert_error (error, MM_CORE_ERROR, MM_CORE_ERROR_FAILED);
+ g_assert_error (error, MM_CORE_ERROR, (gint)expected_error);
g_assert (!cmd);
}
-#define test_common_bnd_cmd_2g_invalid(BANDS_ARRAY) test_common_bnd_cmd_invalid (TRUE, FALSE, FALSE, BANDS_ARRAY)
-#define test_common_bnd_cmd_3g_invalid(BANDS_ARRAY) test_common_bnd_cmd_invalid (FALSE, TRUE, FALSE, BANDS_ARRAY)
-#define test_common_bnd_cmd_4g_invalid(BANDS_ARRAY) test_common_bnd_cmd_invalid (FALSE, FALSE, TRUE, BANDS_ARRAY)
+#define test_common_bnd_cmd_2g_invalid(BANDS_ARRAY) test_common_bnd_cmd_error (TRUE, FALSE, FALSE, BANDS_ARRAY, MM_CORE_ERROR_FAILED)
+#define test_common_bnd_cmd_3g_invalid(BANDS_ARRAY) test_common_bnd_cmd_error (FALSE, TRUE, FALSE, BANDS_ARRAY, MM_CORE_ERROR_FAILED)
+#define test_common_bnd_cmd_4g_invalid(BANDS_ARRAY) test_common_bnd_cmd_error (FALSE, FALSE, TRUE, BANDS_ARRAY, MM_CORE_ERROR_FAILED)
+#define test_common_bnd_cmd_2g_not_found(BANDS_ARRAY) test_common_bnd_cmd_error (TRUE, FALSE, FALSE, BANDS_ARRAY, MM_CORE_ERROR_NOT_FOUND)
+#define test_common_bnd_cmd_3g_not_found(BANDS_ARRAY) test_common_bnd_cmd_error (FALSE, TRUE, FALSE, BANDS_ARRAY, MM_CORE_ERROR_NOT_FOUND)
+#define test_common_bnd_cmd_4g_not_found(BANDS_ARRAY) test_common_bnd_cmd_error (FALSE, FALSE, TRUE, BANDS_ARRAY, MM_CORE_ERROR_NOT_FOUND)
static void
test_telit_get_2g_bnd_flag (void)
@@ -344,6 +348,8 @@ test_telit_get_2g_bnd_flag (void)
MMModemBand dcs = MM_MODEM_BAND_DCS;
MMModemBand pcs = MM_MODEM_BAND_PCS;
MMModemBand g850 = MM_MODEM_BAND_G850;
+ MMModemBand u2100 = MM_MODEM_BAND_UTRAN_1;
+ MMModemBand eutran_i = MM_MODEM_BAND_EUTRAN_1;
/* Test Flag 0 */
bands_array = g_array_sized_new (FALSE, FALSE, sizeof (MMModemBand), 2);
@@ -379,6 +385,13 @@ test_telit_get_2g_bnd_flag (void)
g_array_append_val (bands_array, egsm);
test_common_bnd_cmd_2g_invalid (bands_array);
g_array_unref (bands_array);
+
+ /* Test unmatched band array */
+ bands_array = g_array_sized_new (FALSE, FALSE, sizeof (MMModemBand), 2);
+ g_array_append_val (bands_array, u2100);
+ g_array_append_val (bands_array, eutran_i);
+ test_common_bnd_cmd_2g_not_found (bands_array);
+ g_array_unref (bands_array);
}
static void
@@ -393,6 +406,8 @@ test_telit_get_3g_bnd_flag (void)
MMModemBand u900 = MM_MODEM_BAND_UTRAN_8;
MMModemBand u17iv = MM_MODEM_BAND_UTRAN_4;
MMModemBand u17ix = MM_MODEM_BAND_UTRAN_9;
+ MMModemBand egsm = MM_MODEM_BAND_EGSM;
+ MMModemBand eutran_i = MM_MODEM_BAND_EUTRAN_1;
/* Test flag 0 */
bands_array = g_array_sized_new (FALSE, FALSE, sizeof (MMModemBand), 1);
@@ -474,6 +489,13 @@ test_telit_get_3g_bnd_flag (void)
g_array_append_val (bands_array, u17ix);
test_common_bnd_cmd_3g_invalid (bands_array);
g_array_unref (bands_array);
+
+ /* Test unmatched band array */
+ bands_array = g_array_sized_new (FALSE, FALSE, sizeof (MMModemBand), 2);
+ g_array_append_val (bands_array, egsm);
+ g_array_append_val (bands_array, eutran_i);
+ test_common_bnd_cmd_3g_not_found (bands_array);
+ g_array_unref (bands_array);
}
static void
@@ -482,6 +504,7 @@ test_telit_get_4g_bnd_flag (void)
GArray *bands_array;
MMModemBand eutran_i = MM_MODEM_BAND_EUTRAN_1;
MMModemBand eutran_ii = MM_MODEM_BAND_EUTRAN_2;
+ MMModemBand u2100 = MM_MODEM_BAND_UTRAN_1;
MMModemBand egsm = MM_MODEM_BAND_EGSM;
/* Test flag 1 */
@@ -497,10 +520,11 @@ test_telit_get_4g_bnd_flag (void)
test_common_bnd_cmd_4g ("#BND=0,0,3", bands_array);
g_array_unref (bands_array);
- /* Test invalid bands array */
- bands_array = g_array_sized_new (FALSE, FALSE, sizeof (MMModemBand), 1);
+ /* Test unmatched band array */
+ bands_array = g_array_sized_new (FALSE, FALSE, sizeof (MMModemBand), 2);
g_array_append_val (bands_array, egsm);
- test_common_bnd_cmd_4g_invalid (bands_array);
+ g_array_append_val (bands_array, u2100);
+ test_common_bnd_cmd_4g_not_found (bands_array);
g_array_unref (bands_array);
}