diff options
| author | Ben Chan <benchan@chromium.org> | 2018-08-09 17:00:27 -0700 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2018-08-10 11:06:19 +0200 |
| commit | d21dd6cf1fe93030baa4b8fffe9b7e84d781f186 (patch) | |
| tree | 5b1960210209a8d25ca527d8d5519ad51dd8cb70 /src | |
| parent | b378be0f0d0e433e423f004c5a09db64ed94bb54 (diff) | |
broadband-modem: initialize 'tac' in registration_status_check_ready()
mm-broadband-modem.c:4395:13: error: variable 'tac' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (act == MM_MODEM_ACCESS_TECHNOLOGY_LTE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm-broadband-modem.c:4407:75: note: uninitialized use occurs here
mm_iface_modem_3gpp_update_location (MM_IFACE_MODEM_3GPP (self), lac, tac, cid);
^~~
mm-broadband-modem.c:4395:9: note: remove the 'if' if its condition is always true
if (act == MM_MODEM_ACCESS_TECHNOLOGY_LTE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm-broadband-modem.c:4380:9: error: variable 'tac' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
if (cgreg) {
^~~~~
mm-broadband-modem.c:4407:75: note: uninitialized use occurs here
mm_iface_modem_3gpp_update_location (MM_IFACE_MODEM_3GPP (self), lac, tac, cid);
^~~
mm-broadband-modem.c:4380:5: note: remove the 'if' if its condition is always false
if (cgreg) {
^~~~~~~~~~~~
mm-broadband-modem.c:4280:15: note: initialize the variable 'tac' to silence this warning
gulong tac;
^
= 0
Diffstat (limited to 'src')
| -rw-r--r-- | src/mm-broadband-modem.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c index a685e407..d1afba4d 100644 --- a/src/mm-broadband-modem.c +++ b/src/mm-broadband-modem.c @@ -4344,6 +4344,7 @@ registration_status_check_ready (MMBroadbandModem *self, cereg = FALSE; state = MM_MODEM_3GPP_REGISTRATION_STATE_UNKNOWN; act = MM_MODEM_ACCESS_TECHNOLOGY_UNKNOWN; + tac = 0; lac = 0; cid = 0; parsed = mm_3gpp_parse_creg_response (match_info, |