aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTambet Ingo <tambet@gmail.com>2008-09-01 16:01:55 +0300
committerTambet Ingo <tambet@gmail.com>2008-09-01 16:01:55 +0300
commitc56d5a257b35a8f1072a250df68437cf4ec50bf9 (patch)
tree2eae0b9b0df7d3d52a766b3d6e3cdd722dba6fb5 /src
parent1bb60347b503e1aaf043548b853f19156a31b5e4 (diff)
Handle reading failure replies correctly everywhere.
Diffstat (limited to 'src')
-rw-r--r--src/mm-generic-gsm.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/mm-generic-gsm.c b/src/mm-generic-gsm.c
index 8a32c9e9..f7b7a178 100644
--- a/src/mm-generic-gsm.c
+++ b/src/mm-generic-gsm.c
@@ -194,7 +194,11 @@ get_string_done (MMSerial *serial, const char *reply, gpointer user_data)
{
MMCallbackInfo *info = (MMCallbackInfo *) user_data;
- mm_callback_info_set_result (info, g_strdup (reply), g_free);
+ if (reply)
+ mm_callback_info_set_result (info, g_strdup (reply), g_free);
+ else
+ info->error = g_error_new (MM_MODEM_ERROR, MM_MODEM_ERROR_GENERAL, "%s", "Reading information failed.");
+
mm_callback_info_schedule (info);
}
@@ -809,7 +813,7 @@ scan_done (MMSerial *serial, const char *reply, gpointer user_data)
results = g_ptr_array_new ();
- if (!strncmp (reply, "+COPS: ", 7)) {
+ if (reply && !strncmp (reply, "+COPS: ", 7)) {
/* Got valid reply */
GRegex *r;
GMatchInfo *match_info;
@@ -927,7 +931,7 @@ get_signal_quality_done (MMSerial *serial, const char *reply, gpointer user_data
MMCallbackInfo *info = (MMCallbackInfo *) user_data;
guint32 result = 0;
- if (!strncmp (reply, "+CSQ: ", 6)) {
+ if (reply && !strncmp (reply, "+CSQ: ", 6)) {
/* Got valid reply */
int quality;
int ber;