aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorPaul Bartell <p.bartell@temperednetworks.com>2018-09-04 14:10:26 -0700
committerPaul Bartell <p.bartell@temperednetworks.com>2018-09-04 14:20:19 -0700
commit6e8aab2c4ed38d24c008ae4de36cb7c8bc8e3ca6 (patch)
tree47bc89eb55e782b84b2d94679d253a8853ed5bd7 /src
parent1b3b2e26a7ff4faf536074b8b82d6e4eec11b36c (diff)
broadband-modem-qmi: Pass signal values_result directly rather than duplicating with g_memdup
corrects segfault introduced in 7d8f0600e6de32721112949b65d48108ea640b51 Signed-off-by: Paul Bartell <p.bartell@temperednetworks.com>
Diffstat (limited to 'src')
-rw-r--r--src/mm-broadband-modem-qmi.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c
index 7436d495..a7f9af0f 100644
--- a/src/mm-broadband-modem-qmi.c
+++ b/src/mm-broadband-modem-qmi.c
@@ -9962,8 +9962,9 @@ signal_load_values_context_step (GTask *task)
/* If any result is set, succeed */
if (VALUES_RESULT_LOADED (ctx)) {
g_task_return_pointer (task,
- g_memdup (&ctx->values_result, sizeof (ctx->values_result)),
+ ctx->values_result,
(GDestroyNotify)signal_load_values_result_free);
+ /* Prevent values_result from being freed by signal_load_values_context_free */
ctx->values_result = NULL;
} else {
g_task_return_new_error (task,