aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAleksander Morgado <aleksander@lanedo.com>2011-08-30 11:53:05 +0200
committerJiří Klimeš <jklimes@redhat.com>2011-08-30 11:53:05 +0200
commit4c514bfd6d096b649c5ae2132a914044ef0f45cb (patch)
tree3d62639a5c38fa506e69afb1530d683f6020dd6b /src
parent2a9a6ad79b4bfe5d83e938c929c229a930c513a8 (diff)
gsm/cdma: unsigned integers can't be < 0, so remove unnecessary conditions
It fixes compilation with the llvm/clang compiler as well.
Diffstat (limited to 'src')
-rw-r--r--src/mm-generic-cdma.c2
-rw-r--r--src/mm-generic-gsm.c6
2 files changed, 3 insertions, 5 deletions
diff --git a/src/mm-generic-cdma.c b/src/mm-generic-cdma.c
index 11987a2c..aedc6475 100644
--- a/src/mm-generic-cdma.c
+++ b/src/mm-generic-cdma.c
@@ -591,7 +591,7 @@ crm_done (MMAtSerialPort *port,
if (p) {
errno = 0;
num = strtoul (p, NULL, 10);
- if (num >= 0 && num <= 4 && (errno == 0)) {
+ if (num <= 4 && (errno == 0)) {
MM_GENERIC_CDMA_GET_PRIVATE (user_data)->orig_crm = (guint32) num;
MM_GENERIC_CDMA_GET_PRIVATE (user_data)->cur_crm = (guint32) num;
}
diff --git a/src/mm-generic-gsm.c b/src/mm-generic-gsm.c
index 3caa86bb..78703042 100644
--- a/src/mm-generic-gsm.c
+++ b/src/mm-generic-gsm.c
@@ -2892,10 +2892,8 @@ handle_reg_status_response (MMGenericGsm *self,
if (act != -1)
mm_generic_gsm_update_access_technology (self, etsi_act_to_mm_act (act));
- if (status >= 0) {
- /* Update cached registration status */
- reg_status_updated (self, cgreg_to_reg_type (cgreg), status, NULL);
- }
+ /* Update cached registration status */
+ reg_status_updated (self, cgreg_to_reg_type (cgreg), status, NULL);
return TRUE;
}