aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDan Williams <dcbw@redhat.com>2009-10-26 15:39:34 -0700
committerDan Williams <dcbw@redhat.com>2009-10-26 15:39:34 -0700
commit2887a50b232714702c0eb9009c32d9a6b850888b (patch)
tree038a9d2c44841d4cd81c85a13d8fb8c71e67b859 /src
parent6bc4f0ae8cad621e11d882d2b3813765c86156c2 (diff)
gsm: ignore errors from power-on command
Phones especially don't seem to consistently implement this. For now, we'll hack it out, but later, we'll want to have a class method for power-on instead of just a property so that subclasses can decided for themselves (since they know their hardware better) whether failure of the power-on command is fatal or not.
Diffstat (limited to 'src')
-rw-r--r--src/mm-generic-gsm.c11
1 files changed, 8 insertions, 3 deletions
diff --git a/src/mm-generic-gsm.c b/src/mm-generic-gsm.c
index b63e0bae..7df27a2e 100644
--- a/src/mm-generic-gsm.c
+++ b/src/mm-generic-gsm.c
@@ -332,9 +332,14 @@ enable_done (MMSerialPort *port,
{
MMCallbackInfo *info = (MMCallbackInfo *) user_data;
- if (error)
- info->error = g_error_copy (error);
-
+ /* Ignore power-up command errors, not all devices actually support
+ * CFUN=1.
+ */
+ /* FIXME: instead of just ignoring errors, since we allow subclasses
+ * to override the power-on command, make a class function for powering
+ * on the phone and let the subclass decided whether it wants to handle
+ * errors or ignore them.
+ */
mm_callback_info_schedule (info);
}