diff options
| author | Aleksander Morgado <aleksandermj@chromium.org> | 2022-12-15 21:45:53 +0000 |
|---|---|---|
| committer | Aleksander Morgado <aleksandermj@chromium.org> | 2022-12-18 21:52:51 +0000 |
| commit | a20f2428eea3fa6fd83edeb5f1a844926b4a5b1c (patch) | |
| tree | 18f161a62516c383e9b3e8cd81ca73ffc3769e20 /src/mm-port-qmi.h | |
| parent | 455c4860915b194c654abb6cd49bcbb483ec650b (diff) | |
port-qmi: implement the new generic 'removed' signal
Letting the MMBroadbandModemQmi listen for the notifications of the
QmiDevice was not a good idea, especially since no explicit reference
to the device object was hold in the modem object. This leads to race
conditions in which the QmiDevice outlives the MMBroadbandModemQmi and
the MMPortQmi, and when the "device-removed" signal is triggered, the
program crashes.
The MMPortQmi will now emit its own 'removed' signals when the
underlying QmiDevice emits "device-removed', ensuring that the signal
handler is properly cleared up during the MMPortQmi disposal.
Diffstat (limited to 'src/mm-port-qmi.h')
| -rw-r--r-- | src/mm-port-qmi.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/mm-port-qmi.h b/src/mm-port-qmi.h index 7b434cdb..854b5245 100644 --- a/src/mm-port-qmi.h +++ b/src/mm-port-qmi.h @@ -121,8 +121,6 @@ QmiClient *mm_port_qmi_get_client (MMPortQmi *self, QmiService service, guint flag); -QmiDevice *mm_port_qmi_peek_device (MMPortQmi *self); - typedef struct { QmiDataEndpointType type; guint interface_number; |