diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2020-11-06 12:27:40 +0100 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2020-11-13 08:57:06 +0000 |
| commit | 950abbf8ee8624827d63a0d0186beac81232e8f6 (patch) | |
| tree | 675ff1b0231b196af7530041d167cca7eb4d17fa /src/mm-plugin.c | |
| parent | 519df2544b04ccbc9cf87fbfbdbbaf44edeef75b (diff) | |
core: stop monitoring the 'usb' subsystem
Back in Linux < 3.6 days, the cdc-wdm ports exposed by the QMI driver
were flagged as owned by the 'usb' subsystem. That changed in 3.6 when
the subsystem was renamed to 'usbmisc':
https://mail.gnome.org/archives/networkmanager-list/2012-June/msg00125.html
This patch removes all monitoring of the 'usb' subsystem completely,
which is anyway a valid subsystem but for which we shouldn't need any
special handling. Right now, with newer kernels, we were using that
monitoring exclusively to get notified of full USB device remove
events, which is really not required as we already process the port
removals one by one.
We simplify the logic everywhere that attempted to match either the
'usb' or 'usbmisc' subsystems, and we no longer require the explicit
checks for the port name being named 'cdc-wdm[0-9]*' in the code, as
that is already taken care of by the ID_MM_CANDIDATE udev tag rule.
Diffstat (limited to 'src/mm-plugin.c')
| -rw-r--r-- | src/mm-plugin.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/mm-plugin.c b/src/mm-plugin.c index dc1171d4..a713ddf1 100644 --- a/src/mm-plugin.c +++ b/src/mm-plugin.c @@ -217,10 +217,6 @@ apply_subsystem_filter (MMPlugin *self, for (i = 0; self->priv->subsystems[i]; i++) { if (g_str_equal (subsys, self->priv->subsystems[i])) break; - /* New kernels may report as 'usbmisc' the subsystem */ - else if (g_str_equal (self->priv->subsystems[i], "usb") && - g_str_equal (subsys, "usbmisc")) - break; } /* If we didn't match any subsystem: unsupported */ |