diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2015-05-23 18:17:12 +0200 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2015-08-02 10:39:48 +0200 |
| commit | 9f3801df3f1ee8f5b8d9dfbf7e7a1968fdf85f0b (patch) | |
| tree | 49da5c8c27ded84fc66756b100fe05684e049302 /src/mm-modem-helpers.c | |
| parent | b600e6c9ce1552d95652e1e9623a1880941036d9 (diff) | |
core,voice: remove explicit "NO CARRIER" response matching
This response is already managed by the generic AT serial port and translates
it into a proper error. This change also avoids the Call.Start() call to report
a timeout in the serial port, instead we get a proper no-carrier error.
Before:
$ sudo mmcli -m 0 --voice-create-call="number=12345678"
Successfully created new call:
/org/freedesktop/ModemManager1/Call/1 outgoing (unknown)
$ sudo mmcli -o 1 --start
error: couldn't start the call: 'GDBus.Error:org.freedesktop.ModemManager1.Error.Serial.ResponseTimeout: Serial command timed out'
After:
$ sudo mmcli -m 0 --voice-create-call="number=12345678"
Successfully created new call:
/org/freedesktop/ModemManager1/Call/1 outgoing (unknown)
$ sudo mmcli -o 1 --start
error: couldn't start the call: 'GDBus.Error:org.freedesktop.ModemManager1.Error.Connection.NoCarrier: No carrier'
Diffstat (limited to 'src/mm-modem-helpers.c')
| -rw-r--r-- | src/mm-modem-helpers.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/mm-modem-helpers.c b/src/mm-modem-helpers.c index 4ac1564e..fb0b7fa1 100644 --- a/src/mm-modem-helpers.c +++ b/src/mm-modem-helpers.c @@ -361,18 +361,6 @@ mm_voice_clip_regex_get (void) NULL); } -GRegex * -mm_voice_nocarrier_regex_get (void) -{ - /* Example: - * <CR><LF>NO CARRIER<CR><LF> - */ - return g_regex_new ("\\r\\n\\NO CARRIER\\r\\n", - G_REGEX_RAW | G_REGEX_OPTIMIZE, - 0, - NULL); -} - /*************************************************************************/ /* +CREG: <stat> (GSM 07.07 CREG=1 unsolicited) */ |