diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2021-11-21 14:50:07 +0100 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2021-11-21 14:51:24 +0100 |
| commit | 647a438b435e9dc21c123602b4be758515c51c57 (patch) | |
| tree | 63c108fc3b62dc08f960e56367944a763d043874 /src/mm-bearer-mbim.c | |
| parent | 74ed6eeeffc27c5fb23f3f31342ff5da095d7f48 (diff) | |
bearer-mbim: plug leak when checking if already disconnected fails
If the modem reports any error during the connection status check,
we're creating a GError but never disposing it. We don't need that
GError for anything, so just discard it.
Diffstat (limited to 'src/mm-bearer-mbim.c')
| -rw-r--r-- | src/mm-bearer-mbim.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/mm-bearer-mbim.c b/src/mm-bearer-mbim.c index 1b14b62c..b5b3a8c6 100644 --- a/src/mm-bearer-mbim.c +++ b/src/mm-bearer-mbim.c @@ -685,7 +685,6 @@ check_disconnected_ready (MbimDevice *device, { MMBearerMbim *self; ConnectContext *ctx; - GError *error = NULL; g_autoptr(MbimMessage) response = NULL; guint32 session_id; MbimActivationState activation_state; @@ -693,9 +692,9 @@ check_disconnected_ready (MbimDevice *device, self = g_task_get_source_object (task); ctx = g_task_get_task_data (task); - response = mbim_device_command_finish (device, res, &error); + response = mbim_device_command_finish (device, res, NULL); if (response && - mbim_message_response_get_result (response, MBIM_MESSAGE_TYPE_COMMAND_DONE, &error) && + mbim_message_response_get_result (response, MBIM_MESSAGE_TYPE_COMMAND_DONE, NULL) && mbim_message_connect_response_parse ( response, &session_id, @@ -704,7 +703,7 @@ check_disconnected_ready (MbimDevice *device, NULL, /* ip_type */ NULL, /* context_type */ NULL, /* nw_error */ - &error)) { + NULL)) { mm_obj_dbg (self, "session ID '%u': %s", session_id, mbim_activation_state_get_string (activation_state)); } else activation_state = MBIM_ACTIVATION_STATE_UNKNOWN; |