diff options
author | Aleksander Morgado <aleksander@aleksander.es> | 2018-09-13 11:47:10 +0200 |
---|---|---|
committer | Dan Williams <dcbw@redhat.com> | 2018-09-25 17:55:53 +0000 |
commit | 2a1a0b88fbaafbe3862e1b9130a9a484e84d752f (patch) | |
tree | 0619d8f967e7dd3ea03a729a682679fe28e8fef3 /src/mm-base-manager.c | |
parent | a2705abb247f0f141d41ad8f34d99ce6133073af (diff) |
udev: define all generic tags as symbols
This prevents errors due to nasty typos in the strings.
We define all symbols in a single header file that is NOT considered
part of the API, as there is no need for MM clients to know about
these tags code-wise. These tags are only meaningful when associated
to devices in udev.
Information of each tag is included in the general API documentation.
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/88
Diffstat (limited to 'src/mm-base-manager.c')
-rw-r--r-- | src/mm-base-manager.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mm-base-manager.c b/src/mm-base-manager.c index 3c09089c..be92b5e2 100644 --- a/src/mm-base-manager.c +++ b/src/mm-base-manager.c @@ -30,6 +30,8 @@ #include "mm-kernel-device-generic.h" #include <ModemManager.h> +#include <ModemManager-tags.h> + #include <mm-errors-types.h> #include <mm-gdbus-manager.h> #include <mm-gdbus-test.h> @@ -303,8 +305,8 @@ device_added (MMBaseManager *manager, * * This udev tag applies to each port in a device. In other words, the flag * may be set in some ports, but not in others */ - if (!mm_kernel_device_get_property_as_boolean (port, "ID_MM_CANDIDATE")) { - /* This could mean that device changed, losing its ID_MM_CANDIDATE + if (!mm_kernel_device_get_property_as_boolean (port, ID_MM_CANDIDATE)) { + /* This could mean that device changed, losing its candidate * flags (such as Bluetooth RFCOMM devices upon disconnect. * Try to forget it. */ device_removed (manager, port); |