aboutsummaryrefslogtreecommitdiff
path: root/libmm-glib
diff options
context:
space:
mode:
authorBen Chan <benchan@chromium.org>2019-08-03 09:12:57 -0700
committerBen Chan <benchan@chromium.org>2019-08-03 09:16:39 -0700
commitc6cf7cf094f9974e8f5b9d3640e7d34ebc2a0482 (patch)
treef8c0e9b958bfb5179d1980db35ad00db742df8f8 /libmm-glib
parentee63bf40331349b68d3c7c1f875745042953dc8f (diff)
libmm-glib,firmware-update-settings: handle null self pointer
mm_firmware_update_settings_get_variant() checks for a null `self' pointer when accessing `self->priv->method', but doesn't perform the null check when accessing other members of MMFirmwareUpdateSettingsPrivate. This patch fixes mm_firmware_update_settings_get_variant() to fully handle a null `self' pointer.
Diffstat (limited to 'libmm-glib')
-rw-r--r--libmm-glib/mm-firmware-update-settings.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libmm-glib/mm-firmware-update-settings.c b/libmm-glib/mm-firmware-update-settings.c
index 37c8381e..fc8a45bb 100644
--- a/libmm-glib/mm-firmware-update-settings.c
+++ b/libmm-glib/mm-firmware-update-settings.c
@@ -174,7 +174,7 @@ mm_firmware_update_settings_get_variant (MMFirmwareUpdateSettings *self)
g_variant_builder_add (&builder, "u", method);
g_variant_builder_open (&builder, G_VARIANT_TYPE ("a{sv}"));
- {
+ if (self) {
g_variant_builder_add (&builder,
"{sv}",
PROPERTY_DEVICE_IDS,