aboutsummaryrefslogtreecommitdiff
path: root/libmm-glib/mm-sms-properties.c
diff options
context:
space:
mode:
authorDan Williams <dcbw@redhat.com>2013-04-24 16:48:29 -0500
committerDan Williams <dcbw@redhat.com>2013-04-25 09:18:53 -0500
commit23204111130fca0a93a22508431ad8bb17210bdd (patch)
tree49c021ce47fd7344dc9a0f446391e1e23d832567 /libmm-glib/mm-sms-properties.c
parent18bfefba2dba3f5c77cd971820646d84a85f9334 (diff)
broadband-modem-icera: fix issues checking supported bands
Icera devices include bands that the modem doesn't support in the %IPBM=? list, so the plugin sets the band to its current enabled/disabled value to test whether that band is supported. There were two problems with this approach: 1) Setting an already-enabled band to be enabled apparently isn't a NOP; it might take more than the 3 seconds given, and if the response comes after 3 seconds, this greatly confuses ModemManager because the AT command/reply sequence is now messed up. So increase the timeout to 10 seconds. 2) Why bother checking bands that are already enabled anyway? We already know they are supported, so just don't check those bands at all. This requires some parkour because we use the parsed band array from %IPBM=? to track whether bands are enabled/disabled by indexing into the array, so instead just use two separate arrays. This actually makes the fix for #1 un-needed (because we never enable any bands) but it's good to have #1 anyway.
Diffstat (limited to 'libmm-glib/mm-sms-properties.c')
0 files changed, 0 insertions, 0 deletions