diff options
author | Aleksander Morgado <aleksander@aleksander.es> | 2019-08-07 14:35:31 +0200 |
---|---|---|
committer | Aleksander Morgado <aleksander@gnu.org> | 2019-08-29 20:07:03 +0000 |
commit | 250639e3da531dd91a99950614f95b7227bc84c0 (patch) | |
tree | d17c16491695e8de0af5526c3ef219e54be8cebd /include | |
parent | 07c8a2b4f6366f3f9d9e7c5771a7e75caa95ae20 (diff) |
udev: repurpose ID_MM_DEVICE_IGNORE and new MM_FILTER_RULE_EXPLICIT_BLACKLIST
Until now the ID_MM_DEVICE_IGNORE udev tag was being used in the
internal blacklist of devices shipped by ModemManager when running in
either DEFAULT or PARANOID filter modes. The name of the tag is
extremely misleading because it doesn't really make the full device be
ignored, the tag only applied to TTY ports.
This commit repurposes the tag so that it applies to ANY kind of
port (e.g. TTY, NET, cdc-wdm...) and also to any kind of filter type
(i.e. also applicable in STRICT mode).
The internal blacklist shipped by ModemManager, which should NOT be
used in STRICT mode, uses a new tag name, ID_MM_TTY_BLACKLIST.
The new ID_MM_DEVICE_IGNORE tag is therefore much more usable and its
name is really meaningful. If there are users or third-party projects
adding their own udev rules with the ID_MM_DEVICE_IGNORE tag name,
they should have no problem as the new rule is more restrictive than
the old one.
Diffstat (limited to 'include')
-rw-r--r-- | include/ModemManager-tags.h | 20 |
1 files changed, 17 insertions, 3 deletions
diff --git a/include/ModemManager-tags.h b/include/ModemManager-tags.h index 4be1e791..f7e939a7 100644 --- a/include/ModemManager-tags.h +++ b/include/ModemManager-tags.h @@ -73,6 +73,20 @@ #define ID_MM_DEVICE_PROCESS "ID_MM_DEVICE_PROCESS" /** + * ID_MM_DEVICE_IGNORE: + * + * This is a device-specific tag that allows explicitly requesting to + * ignore all ports exposed by the device. + * + * This tag was originally applicable to TTY ports and only when running + * in DEFAULT or PARANOID filter policy types. Since 1.12, this tag + * applies to all filter types (including STRICT), and to all port types + * (not only TTYs), and is associated to the + * MM_FILTER_RULE_EXPLICIT_BLACKLIST rule. + */ +#define ID_MM_DEVICE_IGNORE "ID_MM_DEVICE_IGNORE" + +/** * ID_MM_PORT_IGNORE: * * This is a port-specific tag that allows explicitly ignoring a given port @@ -82,8 +96,8 @@ */ #define ID_MM_PORT_IGNORE "ID_MM_PORT_IGNORE" -/** - * ID_MM_DEVICE_IGNORE: + /** + * ID_MM_TTY_BLACKLIST: * * This is a device-specific tag that allows explicitly blacklisting * devices that expose TTY devices so that they are never probed. @@ -94,7 +108,7 @@ * * This tag is ignored when the STRICT filter policy is used. */ -#define ID_MM_DEVICE_IGNORE "ID_MM_DEVICE_IGNORE" +#define ID_MM_TTY_BLACKLIST "ID_MM_TTY_BLACKLIST" /** * ID_MM_DEVICE_MANUAL_SCAN_ONLY: |