diff options
author | Eric Caruso <ejcaruso@chromium.org> | 2019-10-29 12:19:22 -0700 |
---|---|---|
committer | Aleksander Morgado <aleksander@aleksander.es> | 2019-10-31 15:36:50 +0100 |
commit | c79d94507323c38c9e12f2255c7d836cc90ba7a2 (patch) | |
tree | 63d478431ca0539b895c78eb16b71d1fcf9ebc72 /docs/reference/api/ModemManager-overview.xml | |
parent | e0f0d62369d0998e5f587cc8e27a8bf5eed98626 (diff) |
mm-modem-helpers-telit: fix undefined bitshifts
Since this plugin uses a bitmask to represent bands, we have
to be wary of shifting outside the precision of the bitmask
storage type. In this case, it was possible to generate 1 << 31
in a signed integer type as an intermediate step of B3G_FLAG,
which is undefined behavior (and usually results in INT_MIN,
breaking comparisons with the value).
Bug was reported to the chromium tracker at crbug.com/1019301
Original patch updated by Aleksander Morgado to leave
MM_MODEM_BAND_TELIT_3G_LAST as MM_MODEM_BAND_UTRAN_19, as that is the
highest 3G band supported by the current implementation. Worth noting
that this was not a real bug as the maximum flag we would have been
setting was (1 << 19) anyway.
Diffstat (limited to 'docs/reference/api/ModemManager-overview.xml')
0 files changed, 0 insertions, 0 deletions