diff options
| author | Lech Perczak <l.perczak@camlintechnologies.com> | 2019-03-21 16:43:49 +0000 |
|---|---|---|
| committer | Dan Williams <dcbw@redhat.com> | 2019-04-26 14:36:32 +0000 |
| commit | 7a6e92727f1034f17d5d21f631f3e904b8a6011a (patch) | |
| tree | 5b3172fbb72a8a6a0c33bfdbc4b8bb696b377d2a /cli/mmcli-common.c | |
| parent | 81ad40d27eca1d04d9036a319d7c8e68f57bd633 (diff) | |
broadband-modem-mbim: parse nw_error in register_state_set_ready only if MBIM_STATUS_FAILURE
Some modems (Namely: Telit LE910 V2) report nonzero NwError code,
outside of 3GPP TS 24.008 - in "register-state set command-done" response,
while status code equals MBIM_STATUS_ERROR_NONE.
In such cases network is operational.
According to MBIM specification 1.0 table 10.5.9.8 "Status codes",
NwError shall be nonzero only if Status Code equals MBIM_STATUS_FAILURE,
and client shall parse NwError only in such cases.
Also, MBIM specification does not explicitly state that 'NwError == 0' equals
no error, rather than that it is unknown error, hence raise an error
unconditionally if MBIM status code is MBIM_STATUS_FAILURE.
Therefore, check NwError IFF MBIM response status code equals
MBIM_STATUS_FAILURE, instead of MBIM_STATUS_SUCCESS.
Fixes: 854c371c8aa9 ("broadband-modem-mbim: implement 3GPP registration request")
Signed-off-by: Lech Perczak <l.perczak@camlintechnologies.com>
Diffstat (limited to 'cli/mmcli-common.c')
0 files changed, 0 insertions, 0 deletions