aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarlo Lobrano <c.lobrano@gmail.com>2022-04-07 10:29:33 +0200
committerCarlo Lobrano <c.lobrano@gmail.com>2022-04-07 10:29:33 +0200
commite175ada2cec4768cc1843f831ad302984cab690c (patch)
treee83f20908b128ac07a3962508a1b13f2812c2e5a
parent7960b365d50c2a9e687a75b46f044e8e52b72b65 (diff)
plugins,telit: remove unnecessary after sim unlock 1s delay
Currently the Telit modem implements modem_after_sim_unlock() with 1s timeout, however the #QSS URC management (introduced later) waits for QSS=1 URC in csim_unlock_periodic_check up to 3s, which makes this 1s delay not necessary anymore. see also: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/3
-rw-r--r--plugins/telit/mm-broadband-modem-telit.c35
1 files changed, 0 insertions, 35 deletions
diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c
index d1ac79af..5a295b27 100644
--- a/plugins/telit/mm-broadband-modem-telit.c
+++ b/plugins/telit/mm-broadband-modem-telit.c
@@ -404,39 +404,6 @@ location_load_capabilities (MMIfaceModemLocation *self,
}
/*****************************************************************************/
-/* After Sim Unlock (Modem interface) */
-
-static gboolean
-modem_after_sim_unlock_finish (MMIfaceModem *self,
- GAsyncResult *res,
- GError **error)
-{
- return g_task_propagate_boolean (G_TASK (res), error);
-}
-
-static gboolean
-after_sim_unlock_ready (GTask *task)
-{
- g_task_return_boolean (task, TRUE);
- g_object_unref (task);
- return G_SOURCE_REMOVE;
-}
-
-static void
-modem_after_sim_unlock (MMIfaceModem *self,
- GAsyncReadyCallback callback,
- gpointer user_data)
-{
- GTask *task;
-
- task = g_task_new (self, NULL, callback, user_data);
-
- /* A short delay is necessary with some SIMs when
- they have just been unlocked. Using 1 second as secure margin. */
- g_timeout_add_seconds (1, (GSourceFunc) after_sim_unlock_ready, task);
-}
-
-/*****************************************************************************/
/* Setup SIM hot swap (Modem interface) */
typedef enum {
@@ -1440,8 +1407,6 @@ iface_modem_init (MMIfaceModem *iface)
iface->load_current_modes_finish = mm_shared_telit_load_current_modes_finish;
iface->set_current_modes = mm_shared_telit_set_current_modes;
iface->set_current_modes_finish = mm_shared_telit_set_current_modes_finish;
- iface->modem_after_sim_unlock = modem_after_sim_unlock;
- iface->modem_after_sim_unlock_finish = modem_after_sim_unlock_finish;
iface->setup_sim_hot_swap = modem_setup_sim_hot_swap;
iface->setup_sim_hot_swap_finish = modem_setup_sim_hot_swap_finish;
}