diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2021-04-08 22:47:17 +0200 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2021-04-29 10:13:22 +0000 |
| commit | d5041cc814934595c7ec3f30e9f0168b191dcea2 (patch) | |
| tree | b7f382d827fca5c2370dc26595c615fa1eb58e0c | |
| parent | 55f8e3b9a715f8122eb51ca8cb8a772552c604ef (diff) | |
iface-modem-3gpp: ignore 'profile-id' and 'apn-type' matching initial EPS settings
We should not try to match the 'profile-id', as that setting is not
available in the input bearer settings provided by the user.
And we should not try to match the 'apn-type', as not all
implementations support it and it's not really necessary for this
purpose anyway.
| -rw-r--r-- | src/mm-iface-modem-3gpp.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c index 93899355..61e492a4 100644 --- a/src/mm-iface-modem-3gpp.c +++ b/src/mm-iface-modem-3gpp.c @@ -30,14 +30,20 @@ #define SUBSYSTEM_3GPP "3gpp" -/* When comparing EPS bearer settings take into account that PASSWORD may not always - * be readable, and apply very loose matching for all fields. Also, some implementations - * may allow configuring roaming allowance in the initial EPS bearer, but that is also - * not common. */ +/* When comparing EPS bearer settings take into account that: + * - 'password' may not always be readable. + * - 'apn-type' may not always be supported. + * - 'profile-id' will not be known in the requested settings + * - we ignore settings not applicable to profiles, like 'allow-roaming' or + * 'rm-protocol'. + * - we apply very loose matching for all fields. + */ #define MM_BEARER_PROPERTIES_CMP_FLAGS_EPS \ (MM_BEARER_PROPERTIES_CMP_FLAGS_LOOSE | \ + MM_BEARER_PROPERTIES_CMP_FLAGS_NO_PROFILE_ID | \ MM_BEARER_PROPERTIES_CMP_FLAGS_NO_PASSWORD | \ MM_BEARER_PROPERTIES_CMP_FLAGS_NO_ALLOW_ROAMING | \ + MM_BEARER_PROPERTIES_CMP_FLAGS_NO_APN_TYPE | \ MM_BEARER_PROPERTIES_CMP_FLAGS_NO_RM_PROTOCOL) /*****************************************************************************/ |