diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2018-06-14 14:34:05 +0200 |
|---|---|---|
| committer | Dan Williams <dcbw@redhat.com> | 2018-10-16 17:09:21 +0000 |
| commit | cfdd6ffc95e611452281fc74bd403bdab9d2c79c (patch) | |
| tree | 96d5a7208c0ddfe862e28b75b94666c9adcdd21e | |
| parent | 4409ccffccf781bf50f354b7ba193432e4cf8b73 (diff) | |
base-call: don't update state twice
The mm_gdbus_call_set_() methods update the properties in the same way
as via g_object_set(), no need to do it twice.
| -rw-r--r-- | src/mm-base-call.c | 11 | ||||
| -rw-r--r-- | src/mm-iface-modem-voice.c | 1 |
2 files changed, 1 insertions, 11 deletions
diff --git a/src/mm-base-call.c b/src/mm-base-call.c index 8f9f3fda..c28ce476 100644 --- a/src/mm-base-call.c +++ b/src/mm-base-call.c @@ -551,18 +551,9 @@ mm_base_call_change_state (MMBaseCall *self, if (old_state == new_state) return; - g_object_set (self, - "state", new_state, - "state-reason", reason, - NULL); - mm_gdbus_call_set_state (MM_GDBUS_CALL (self), new_state); mm_gdbus_call_set_state_reason (MM_GDBUS_CALL (self), reason); - - mm_gdbus_call_emit_state_changed (MM_GDBUS_CALL (self), - old_state, - new_state, - reason); + mm_gdbus_call_emit_state_changed (MM_GDBUS_CALL (self), old_state, new_state, reason); } void diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index eabb0681..844b8310 100644 --- a/src/mm-iface-modem-voice.c +++ b/src/mm-iface-modem-voice.c @@ -99,7 +99,6 @@ mm_iface_modem_voice_update_incoming_call_number (MMIfaceModemVoice *self, call = mm_call_list_get_new_incoming (list); if (call) { - g_object_set (call, "number", number, NULL); mm_gdbus_call_set_number (MM_GDBUS_CALL (call), number); /* |