aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Williams <dan@ioncontrol.co>2025-03-08 14:43:02 -0600
committerDan Williams <dan@ioncontrol.co>2025-05-07 22:59:51 -0500
commit0cb1c1f157e2a4d2f75aeecc9874246359d0ca12 (patch)
treefa8b78b75200f29ea1bec73996ef69497f8cc3c6
parent564bdab99e9a52f9e100dbcc4439b3d2c71f5f04 (diff)
broadband-modem-qmi,mbim: remove redundant port closes
This will just be done immediately after by MMBaseModem's dispose() handler. Signed-off-by: Dan Williams <dan@ioncontrol.co>
-rw-r--r--src/mm-broadband-modem-mbim.c4
-rw-r--r--src/mm-broadband-modem-qmi.c11
2 files changed, 0 insertions, 15 deletions
diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c
index 3df43903..8116d201 100644
--- a/src/mm-broadband-modem-mbim.c
+++ b/src/mm-broadband-modem-mbim.c
@@ -10416,10 +10416,6 @@ dispose (GObject *object)
/* Explicitly remove notification handler */
self->priv->setup_flags = PROCESS_NOTIFICATION_FLAG_NONE;
common_setup_cleanup_unsolicited_events_sync (self, mbim, FALSE);
-
- /* If we did open the MBIM port during initialization, close it now */
- if (mm_port_mbim_is_open (mbim))
- mm_port_mbim_close (mbim, NULL, NULL);
}
g_clear_object (&self->priv->unlock_retries);
diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c
index 3a91a285..996f91e2 100644
--- a/src/mm-broadband-modem-qmi.c
+++ b/src/mm-broadband-modem-qmi.c
@@ -15002,17 +15002,6 @@ static void
dispose (GObject *object)
{
MMBroadbandModemQmi *self = MM_BROADBAND_MODEM_QMI (object);
- MMPortQmi *qmi;
-
- /* If any port cleanup is needed, it must be done during dispose(), as
- * the modem object will be affected by an explicit g_object_run_dispose()
- * that will remove all port references right away */
- qmi = mm_broadband_modem_qmi_peek_port_qmi (self);
- if (qmi) {
- /* If we did open the QMI port during initialization, close it now */
- if (mm_port_qmi_is_open (qmi))
- mm_port_qmi_close (qmi, NULL, NULL);
- }
g_list_free_full (self->priv->firmware_list, g_object_unref);
self->priv->firmware_list = NULL;