diff options
author | Aleksander Morgado <aleksandermj@chromium.org> | 2024-04-04 14:22:47 +0000 |
---|---|---|
committer | Dan Williams <dan@bigw.org> | 2024-04-12 01:17:14 +0000 |
commit | 04e59852a9c6d326a7c87a1a7b39cf7abbee51cf (patch) | |
tree | 3e77e71792c1ace2bcceff8262c393c93545cf09 | |
parent | a18d9d621b218e0cb2c5a7046f3d03d87673b9a5 (diff) |
broadband-modem: remove unnecessary early check for AT ports
There is no need for an explicit early check, the at_command()
operation will do that implicitly.
-rw-r--r-- | src/mm-broadband-modem.c | 26 |
1 files changed, 1 insertions, 25 deletions
diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c index 807ea611..c31b0037 100644 --- a/src/mm-broadband-modem.c +++ b/src/mm-broadband-modem.c @@ -9544,7 +9544,6 @@ typedef struct { } DetailedRegistrationStateResults; typedef struct { - MMPortSerialAt *port; MMModemCdmaRegistrationState cdma1x_state; MMModemCdmaRegistrationState evdo_state; } DetailedRegistrationStateContext; @@ -9561,13 +9560,6 @@ detailed_registration_state_result_new (DetailedRegistrationStateContext *ctx) return results; } -static void -detailed_registration_state_context_free (DetailedRegistrationStateContext *ctx) -{ - g_object_unref (ctx->port); - g_free (ctx); -} - static gboolean modem_cdma_get_detailed_registration_state_finish (MMIfaceModemCdma *self, GAsyncResult *res, @@ -9708,32 +9700,16 @@ modem_cdma_get_detailed_registration_state (MMIfaceModemCdma *self, GAsyncReadyCallback callback, gpointer user_data) { - MMPortSerialAt *port; - GError *error = NULL; DetailedRegistrationStateContext *ctx; GTask *task; - /* The default implementation to get detailed registration state - * requires the use of an AT port; so if we cannot get any, just - * return the error */ - port = mm_base_modem_peek_best_at_port (MM_BASE_MODEM (self), &error); - if (!port) { - g_task_report_error (self, - callback, - user_data, - modem_cdma_get_detailed_registration_state, - error); - return; - } - /* Setup context */ ctx = g_new0 (DetailedRegistrationStateContext, 1); - ctx->port = g_object_ref (port); ctx->cdma1x_state = cdma1x_state; ctx->evdo_state = evdo_state; task = g_task_new (self, NULL, callback, user_data); - g_task_set_task_data (task, ctx, (GDestroyNotify)detailed_registration_state_context_free); + g_task_set_task_data (task, ctx, g_free); /* NOTE: If we get this generic implementation of getting detailed * registration state called, we DO know that we have Sprint commands |