aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMadhav <madhavadas@google.com>2023-10-19 19:59:48 +0000
committerMadhav <madhavadas@google.com>2023-10-19 19:59:48 +0000
commit48ee4d3012232316d7a580ef26f08133ba1d5ed5 (patch)
tree039a3333f6a5bdbc734cf1a4b9883eba12932c7b
parent74904b3cb1a18e7dbbc8613e4afbf739a51c7c53 (diff)
mm-port-probe: Invoke the mm_port_mbim_open function with a GCancellable object
After the modem recovers, the ports are up but not yet responsive. When MM tries to probe the ports, they do not respond. As a result, the probing tasks are left ongoing, waiting for a response from the modem. If the modem drops off the bus for any reason, the cdc-wdm port probing task is not immediately canceled. This patch fixes this issue by passing a cancellable object to mm_port_mbim_open(). In other words, the patch ensures that the cdc-wdm port probing task is canceled if the modem drops off the bus before the task completes. This prevents the task from preventing other port probing tasks from starting.
-rw-r--r--src/mm-port-probe.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mm-port-probe.c b/src/mm-port-probe.c
index 85f30e60..26e6a4ee 100644
--- a/src/mm-port-probe.c
+++ b/src/mm-port-probe.c
@@ -595,7 +595,7 @@ wdm_probe_mbim (MMPortProbe *self)
#if defined WITH_QMI && QMI_MBIM_QMUX_SUPPORTED
FALSE, /* Don't check QMI over MBIM support at this stage */
#endif
- NULL,
+ g_task_get_cancellable (self->priv->task),
(GAsyncReadyCallback) mbim_port_open_ready,
self);
#else