diff options
| author | Aleksander Morgado <aleksandermj@chromium.org> | 2022-08-15 21:59:17 +0000 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2022-08-16 16:40:16 +0000 |
| commit | f6c1939f5c48ae7124212ef731c1fb552a8d6ee7 (patch) | |
| tree | 91503baa836905d438067583e91b22fa97d24f67 | |
| parent | b1bdc34130aeb1f96520265bb194637c1a60bbc3 (diff) | |
broadband-modem-mbim: remove context type comparison on disconnection reports
Since 1.18 the user can request a different APN type during the
connection attempt, which translates into a different context type in
the actual MBIM Connect Set request. Therefore, the context type of a
given connection is no longer always INTERNET.
Matching by the session id to report disconnections should be more
than enough, which also helps to cover the case where the modem
doesn't report the original context type used during the
attempt (e.g. reporting NONE unconditionally).
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/614
| -rw-r--r-- | src/mm-broadband-modem-mbim.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c index 10eb2b95..602415d6 100644 --- a/src/mm-broadband-modem-mbim.c +++ b/src/mm-broadband-modem-mbim.c @@ -4651,8 +4651,7 @@ basic_connect_notification_connect (MMBroadbandModemMbim *self, if (!bearer_list) return; - if (mbim_uuid_to_context_type (context_type) == MBIM_CONTEXT_TYPE_INTERNET && - activation_state == MBIM_ACTIVATION_STATE_DEACTIVATED) { + if (activation_state == MBIM_ACTIVATION_STATE_DEACTIVATED) { ReportDisconnectedStatusContext ctx; g_autoptr(GError) connection_error = NULL; |