diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2019-12-23 13:56:28 +0100 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2020-01-30 11:59:14 +0100 |
| commit | e8c64445ccebc615abb28f7e172257fc22b64cf6 (patch) | |
| tree | 049c208200b4b6ce515ddcfa47d70691d6f4fb12 | |
| parent | b1d4c9063cb6c263a98a1538ed68989f58640d15 (diff) | |
iface-modem-voice: fix warnings with -Wimplicit-fallthrough
mm-iface-modem-voice.c: In function ‘interface_disabling_step’:
mm-iface-modem-voice.c:2589:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
2589 | ctx->step++;
| ~~~~~~~~~^~
mm-iface-modem-voice.c:2591:5: note: here
2591 | case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS:
| ^~~~
...
| -rw-r--r-- | src/mm-iface-modem-voice.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/src/mm-iface-modem-voice.c b/src/mm-iface-modem-voice.c index e658583f..9f3b7ed5 100644 --- a/src/mm-iface-modem-voice.c +++ b/src/mm-iface-modem-voice.c @@ -2596,8 +2596,8 @@ interface_disabling_step (GTask *task) switch (ctx->step) { case DISABLING_STEP_FIRST: - /* Fall down to next step */ ctx->step++; + /* fall through */ case DISABLING_STEP_DISABLE_UNSOLICITED_EVENTS: /* Allow cleaning up unsolicited events */ @@ -2609,8 +2609,8 @@ interface_disabling_step (GTask *task) task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case DISABLING_STEP_CLEANUP_UNSOLICITED_EVENTS: /* Allow cleaning up unsolicited events */ @@ -2622,8 +2622,8 @@ interface_disabling_step (GTask *task) task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case DISABLING_STEP_LAST: /* We are done without errors! */ @@ -2759,8 +2759,8 @@ interface_enabling_step (GTask *task) switch (ctx->step) { case ENABLING_STEP_FIRST: - /* Fall down to next step */ ctx->step++; + /* fall through */ case ENABLING_STEP_SETUP_UNSOLICITED_EVENTS: /* Allow setting up unsolicited events to get notified of incoming calls */ @@ -2772,8 +2772,8 @@ interface_enabling_step (GTask *task) task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case ENABLING_STEP_ENABLE_UNSOLICITED_EVENTS: /* Allow setting up unsolicited events to get notified of incoming calls */ @@ -2785,8 +2785,8 @@ interface_enabling_step (GTask *task) task); return; } - /* Fall down to next step */ ctx->step++; + /* fall through */ case ENABLING_STEP_LAST: /* We are done without errors! */ @@ -2896,8 +2896,8 @@ interface_initialization_step (GTask *task) switch (ctx->step) { case INITIALIZATION_STEP_FIRST: - /* Fall down to next step */ ctx->step++; + /* fall through */ case INITIALIZATION_STEP_CHECK_SUPPORT: /* Always check voice support when we run initialization, because @@ -2970,9 +2970,8 @@ interface_initialization_step (GTask *task) } g_object_unref (list); - /* Fall down to next step */ ctx->step++; - } + } /* fall through */ case INITIALIZATION_STEP_LAST: /* Setup all method handlers */ |