diff options
| author | Andrew Lassalle <andrewlassalle@chromium.org> | 2020-11-03 12:36:31 -0800 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2020-11-05 09:07:55 +0000 |
| commit | d7288861a595db7f07b8ecf6bdc30d957b8b6843 (patch) | |
| tree | 514728ffb70e3180a68cbd94022130f96767b70f | |
| parent | 30f0824ea1473f5d63a27fa4c8095a5b2858ee2d (diff) | |
mm-kernel-device: Fix cmp to exclude subtypes
If multiple kernel device types inherit from MMKernerDevice, and those
are compared against each other, the current logic returns TRUE if the
G_OBJECT_TYPE of one of them is smaller than the other. This function is
checking for equality, so returning FALSE is enough.
| -rw-r--r-- | src/kerneldevice/mm-kernel-device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/kerneldevice/mm-kernel-device.c b/src/kerneldevice/mm-kernel-device.c index fa865394..cf45447f 100644 --- a/src/kerneldevice/mm-kernel-device.c +++ b/src/kerneldevice/mm-kernel-device.c @@ -204,7 +204,7 @@ mm_kernel_device_cmp (MMKernelDevice *a, g_return_val_if_fail (MM_IS_KERNEL_DEVICE (b), FALSE); if (G_OBJECT_TYPE (a) != G_OBJECT_TYPE (b)) - return G_OBJECT_TYPE (a) < G_OBJECT_TYPE (b); + return FALSE; return (MM_KERNEL_DEVICE_GET_CLASS (a)->cmp ? MM_KERNEL_DEVICE_GET_CLASS (a)->cmp (a, b) : |