aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAleksander Morgado <aleksander@aleksander.es>2019-11-20 16:11:55 +0100
committerAleksander Morgado <aleksander@aleksander.es>2020-01-30 11:59:14 +0100
commitce5689112d927cf23162777024d586c2ebf0ab31 (patch)
tree751ed5bf8bb793063e6342a4880e9eba29ea3547
parent850c6636bf26d38bdd2cd0e5d6668fe53bb0072a (diff)
core,base-sim: fix warnings with -Wimplicit-fallthrough
mm-base-sim.c:1590:18: warning: this statement may fall through [-Wimplicit-fallthrough=] 1590 | ctx->step++; | ~~~~~~~~~^~ mm-base-sim.c:1592:5: note: here 1592 | case INITIALIZATION_STEP_SIM_IDENTIFIER: | ^~~~ mm-base-sim.c:1606:18: warning: this statement may fall through [-Wimplicit-fallthrough=] 1606 | ctx->step++; | ~~~~~~~~~^~ mm-base-sim.c:1608:5: note: here 1608 | case INITIALIZATION_STEP_IMSI: | ^~~~ mm-base-sim.c:1622:18: warning: this statement may fall through [-Wimplicit-fallthrough=] 1622 | ctx->step++; | ~~~~~~~~~^~ mm-base-sim.c:1624:5: note: here 1624 | case INITIALIZATION_STEP_OPERATOR_ID: | ^~~~ mm-base-sim.c:1638:18: warning: this statement may fall through [-Wimplicit-fallthrough=] 1638 | ctx->step++; | ~~~~~~~~~^~ mm-base-sim.c:1640:5: note: here 1640 | case INITIALIZATION_STEP_OPERATOR_NAME: | ^~~~ mm-base-sim.c:1654:18: warning: this statement may fall through [-Wimplicit-fallthrough=] 1654 | ctx->step++; | ~~~~~~~~~^~ mm-base-sim.c:1656:5: note: here 1656 | case INITIALIZATION_STEP_EMERGENCY_NUMBERS: | ^~~~ mm-base-sim.c:1670:18: warning: this statement may fall through [-Wimplicit-fallthrough=] 1670 | ctx->step++; | ~~~~~~~~~^~ mm-base-sim.c:1672:5: note: here 1672 | case INITIALIZATION_STEP_LAST: | ^~~~
-rw-r--r--src/mm-base-sim.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/mm-base-sim.c b/src/mm-base-sim.c
index 7dec5d59..8a5b4ee5 100644
--- a/src/mm-base-sim.c
+++ b/src/mm-base-sim.c
@@ -1586,8 +1586,8 @@ interface_initialization_step (GTask *task)
switch (ctx->step) {
case INITIALIZATION_STEP_FIRST:
- /* Fall down to next step */
ctx->step++;
+ /* Fall through */
case INITIALIZATION_STEP_SIM_IDENTIFIER:
/* SIM ID is meant to be loaded only once during the whole
@@ -1602,8 +1602,8 @@ interface_initialization_step (GTask *task)
task);
return;
}
- /* Fall down to next step */
ctx->step++;
+ /* Fall through */
case INITIALIZATION_STEP_IMSI:
/* IMSI is meant to be loaded only once during the whole
@@ -1618,8 +1618,8 @@ interface_initialization_step (GTask *task)
task);
return;
}
- /* Fall down to next step */
ctx->step++;
+ /* Fall through */
case INITIALIZATION_STEP_OPERATOR_ID:
/* Operator ID is meant to be loaded only once during the whole
@@ -1634,8 +1634,8 @@ interface_initialization_step (GTask *task)
task);
return;
}
- /* Fall down to next step */
ctx->step++;
+ /* Fall through */
case INITIALIZATION_STEP_OPERATOR_NAME:
/* Operator Name is meant to be loaded only once during the whole
@@ -1650,8 +1650,8 @@ interface_initialization_step (GTask *task)
task);
return;
}
- /* Fall down to next step */
ctx->step++;
+ /* Fall through */
case INITIALIZATION_STEP_EMERGENCY_NUMBERS:
/* Emergency Numbers are meant to be loaded only once during the whole
@@ -1666,8 +1666,8 @@ interface_initialization_step (GTask *task)
task);
return;
}
- /* Fall down to next step */
ctx->step++;
+ /* Fall through */
case INITIALIZATION_STEP_LAST:
/* We are done without errors! */